Gradle 9 Support #937
Gradle 9 Support #937
Conversation
| // This method is needed for Groovy interop | ||
| // See https://discuss.gradle.org/t/multi-level-dsl-for-plugin-extension/19029/16 | ||
| ConfigureUtil.configure(configuration, customReporters) | ||
| fun customReporters(configuration: Action<NamedDomainObjectContainer<CustomReporter>>) { |
There was a problem hiding this comment.
Is this a binary API breaking change? IE. if projects are depending upon this plugin as a direct dependency rather than as a script, anything compiled against our APIs won't work anymore, correct?
There was a problem hiding this comment.
possibly... I know gradle has some stuff to auto convert between SAMs and Closures, but I'm not sure if it would help here
There was a problem hiding this comment.
in any case, this is the way is is supposed to be done in Gradle now, so I think at most, I'll make a note about it in release notes
| MAX_GRADLE_MIN_AGP( | ||
| GradleVersion.version(TestVersions.maxSupportedGradleVersion), | ||
| TestVersions.minAgpVersion, | ||
| TestVersions.minSupportedKotlinPluginVersion | ||
| ), |
There was a problem hiding this comment.
the old AGP doesnt work with Gradle 9, so this combination no longer works
wakingrufus
force-pushed
the
gradle-9
branch
2 times, most recently
from
bd66673 to
accef98
Compare
| @@ -25,7 +29,6 @@ object TestVersions { | |||
| @Retention(AnnotationRetention.RUNTIME) | |||
| annotation class GradleTestVersions( | |||
| val minVersion: String = TestVersions.minSupportedGradleVersion, | |||
| val maxVersion: String = TestVersions.maxSupportedGradleVersion, | |||
There was a problem hiding this comment.
we were never overriding this anyway, and making it an annotation property was preventing me from making it dynamic based Java version
wakingrufus
force-pushed
the
gradle-9
branch
7 times, most recently
from
6fe7256 to
b1f3923
Compare
remove use of ConfigureUtil update max kotlin version for testing to 2.2.0
|
What problems does this PR solve? I've been using ktlint-gradle 13.0.0 with Gradle 9.0.0 for more than two weeks, without any problems. When I execute |
2 main things:
|
|
OK, so the plugin worked with Gradle 9 already in 13.0.0, just the custom reporters handling did not, and this part was fixed here. |
Gradle 9 Support
remove use of ConfigureUtil
update max kotlin version for testing to 2.2.0