Skip to content

Commit 2643477

Browse files
committed
Refactor: remove one liner ifs
1 parent 0db6844 commit 2643477

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

lib/rules/availableRules.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ const rules = {
22
endWithDot: input => ({
33
message: () => 'The commit message can not end with a dot',
44
check: () => {
5-
if (input[input.length - 1] === '.') return false;
5+
if (input[input.length - 1] === '.') {
6+
return false;
7+
}
68

79
return true;
810
},
@@ -16,15 +18,19 @@ const rules = {
1618
number = Number.POSITIVE_INFINITY;
1719
}
1820

19-
if (input.length > number) return false;
21+
if (input.length > number) {
22+
return false;
23+
}
2024

2125
return true;
2226
},
2327
}),
2428
minChar: (input, config) => ({
2529
message: () => `The commit message has to be at least ${config.rules['min-char']} character.`,
2630
check: () => {
27-
if (input.length < config.rules['min-char']) return false;
31+
if (input.length < config.rules['min-char']) {
32+
return false;
33+
}
2834

2935
return true;
3036
},

lib/rules/ruleWarningMessages.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ const ruleWarningMessages = (input, config) => {
1010
const camelCaseRuleName = (rule[0]).replace(/-([a-z])/g, g => (g[1].toUpperCase()));
1111
const ruleIs = rules[camelCaseRuleName](input, config).check();
1212

13-
if (!ruleIs) warningMessage += `${rules[camelCaseRuleName](input, config).message()}\n`;
13+
if (!ruleIs) {
14+
warningMessage += `${rules[camelCaseRuleName](input, config).message()}\n`;
15+
}
1416
});
1517

1618
return warningMessage;

0 commit comments

Comments
 (0)