add unit tests to fa2domain #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Awa Synthia <[email protected]>
Signed-off-by: Awa Synthia <[email protected]>
This was referenced Oct 8, 2024
Collaborator
|
Bringing this PR up to date with main and making final adjustments so we can get it ready to merge. Thanks again @awasyn for the original work here. |
the-mayer
approved these changes
Nov 7, 2025
Collaborator
the-mayer
left a comment
the-mayer
left a comment
There was a problem hiding this comment.
Slight modification to test folder structure and pathing. Thanks!
jananiravi
approved these changes
Nov 8, 2025
Member
jananiravi
left a comment
jananiravi
left a comment
There was a problem hiding this comment.
Thanks a ton for getting the ball rolling, @awasyn, and for the review @the-mayer! In theory, looks good to me -- could/did you check this in practice? If so, happy to merge!
the-mayer
added a commit
to awasyn/MolEvolvR
that referenced
this pull request
Nov 10, 2025
More descriptive messaging Co-authored-by: Janani Ravi <[email protected]>
Additional comments, adding structure to test file Co-authored-by: Janani Ravi <[email protected]>
Co-authored-by: Janani Ravi <[email protected]>
the-mayer
added a commit
to awasyn/MolEvolvR
that referenced
this pull request
Nov 10, 2025
- document package data - use package data in function - adjust test to validate ingested sample colnames References: JRaviLab#75 (comment) Co-authored-by: Jananiravi <[email protected]>
- document package data - use package data in function - adjust test to validate ingested sample colnames References: JRaviLab#75 (comment) Co-authored-by: Janani Ravi <[email protected]>
References: JRaviLab#75 (comment) Co-authored-by: Janani Ravi <[email protected]>
jananiravi
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to fa2domain using testthat
[FEAT] Create Unit tests for functions #29
Enhancement (unit tests).
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.
@the-mayer