-
Notifications
You must be signed in to change notification settings - Fork 10
Misc fixes #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vincerubinetti
wants to merge
20
commits into
main
Choose a base branch
from
misc-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Misc fixes #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for molevolvr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c6584bc to
e6afcef
Compare
vincerubinetti
added a commit
to krishnanlab/meta2onto
that referenced
this pull request
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
Apologies, this became a big bucket of random fixes and improvements. But the diff looks worse than it is, due to tailwind re-linting, updating icons, indentation changes (un/wrapping elements), etc. You can safely glaze over those things. Just spot checking the app for equivalent (or better) behavior from main would be good.
This PR also incorporates the lessons learned in krishnanlab/meta2onto#5.
Roughly in order of diff, more important things bolded:
prettier-plugin-tailwindcssjust to format.cssfiles. (more than just formatting, can catch CSS bugs like applying two conflicting classes)prettier-plugin-css-orderplugin, as it's barely necessary when 99% of styles are using tailwindtype="button"and instead prevent unwanted behavior more simply in form component