-
Notifications
You must be signed in to change notification settings - Fork 1
Add CohpAndDosComponent #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@naik-aakash That's amazing! I think we might have to think together with MP team what to do when there are many local environments (maybe, we only show the most important ones first etc.) The whole structure, including the environments, was too messy, I guess? We could have it as an additional option if you think it is worth the effort. |
neighbour_weights = [ | ||
i["edge_properties"]["ICOHP"] for i in local_env_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure you can simply assign this to each bond by order. If you remember, there might have been a bug here. This is something to recheck.
Hi @JaGeo, thanks. That's a good point. Currently, all the environments identified will always be stacked in two columns, one below the other. Similar to ChemEnv on MP website. So it should not look messy, I imagine. But yeah, something to discuss. Also, I could not find the best place to put the whole structure in the current layout. I had looked at very small, simple examples, so I cannot comment on whether it will look messy. |
Hi @JaGeo ,
I have now added the CohpAndDosComponent to this branch. Currently, one can switch between bonding analysis type interactively and corresponding plot, text descriptions and environments identified are updated automatically.
Features added
Todos