Skip to content

Update to Valhalla #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update to Valhalla #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5675311
Update to Valhalla
koppor Aug 2, 2024
8fad7cf
Comment out debug log (#11568)
subhramit Aug 3, 2024
5c30ac1
Fix typos in CHANGELOG.md
koppor Aug 4, 2024
0cf63e5
Merge remote-tracking branch 'upstream/main' into ea-valhalla
koppor Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/deployment-jdk-ea.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest, buildjet-4vcpu-ubuntu-2204-arm]
jdk: [22]
jdk: [23] # must match the Valhalla version presented at https://jdk.java.net/valhalla/
javafx: [23]
include:
- os: ubuntu-latest
Expand Down Expand Up @@ -92,11 +92,11 @@ jobs:
uses: gittools/actions/gitversion/[email protected]

# JDK
- name: 'Set up JDK ${{ matrix.jdk }}'
uses: actions/setup-java@v4
- name: 'Set up jdk.java.net valhalla'
uses: oracle-actions/setup-java@v1
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
website: jdk.java.net
release: valhalla # or loom, panama, ...
- name: 'Set JDK${{ matrix.jdk }} env var'
shell: bash
run: echo "JDK${{ matrix.jdk }}=$JAVA_HOME" >> $GITHUB_ENV
Expand Down Expand Up @@ -185,7 +185,7 @@ jobs:
sed -i "/javafx {/{n;s#version = \".*\"#version = \"${JAVAFX}\"#}" build.gradle && cat build.gradle

# Gradle
- name: Set up JDK
- name: Set up JDK (for Gradle)
uses: actions/setup-java@v4
with:
java-version: 21
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Fixed

- We fixed an issue where the 'Check for updates' preference was not saved. [#11485](https://github.com/JabRef/jabref/pull/11485)
- We fixed an issue where the "Check for updates" preference was not saved. [#11485](https://github.com/JabRef/jabref/pull/11485)
- We fixed an issue where an exception was thrown after changing "show preview as a tab" in the preferences. [#11515](https://github.com/JabRef/jabref/pull/11515)
- We fixed an issue where a new unsaved library was not marked with an asterisk [#11519](https://github.com/JabRef/jabref/pull/11519)
- We fixed an issue where a new unsaved library was not marked with an asterisk. [#11519](https://github.com/JabRef/jabref/pull/11519)
- We fixed an issue where JabRef starts without window decorations. [#11440](https://github.com/JabRef/jabref/pull/11440)

### Removed
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/tinylog.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ exception = strip: jdk.internal

[email protected] = debug

[email protected] = debug
#[email protected] = debug