-
Notifications
You must be signed in to change notification settings - Fork 15
Use prettier-java #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prettier-java #717
Conversation
6713d0c to
bbd19d9
Compare
|
Failing tests for non-maintainers?? What a privilege to be a maintainer 😆 |
|
Are there any clashes with how we organize imports? |
We will follow the import guide of prettier-java - and ignore our wishes. (I don't read imports, I just want to have them conflict-free) WDYT? |
|
Do we accept the issue jhipster/prettier-java#777 for now? |
|
Oh, sorry, I deleted my message because mobile github messed up the history of conversation. Tldr; accept everything as is |
|
It's not ideal, but if it allows me to format and forget - then I will go for it |
|
We opted to continue with IntelliJ - JabRef#13885 |
Use prettier-java.
Seems to be maintained. And better than two years ago (this PR is a follow-up to JabRef#10646)
Notes:
package.jsonnevertheless)Note on 80 chars
It seems to be well-thought of
It is not the hard upper allowed line length limit. It is a way to say to Prettier roughly how long you’d like lines to be.
Source: https://prettier.io/docs/options
Steps to test
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)