feat: fetcher from clipboard and auto-select identifier type if valid (#13111)

* feat: fetcher from clipboard and auto-select identifier type if valid

* test: add unit tests for identifier detection (DOI, ISBN, arXiv, RFC)

* Update Changelog

* test: rewrite identifier detection tests to match JabRef code style

* test: update identifier detection tests to follow JabRef assertion style

* Refactor: Extract identifier detection and fetcher matching logic in NewEntryView

* Test: Move identifier detection unit tests to CompositeIdFetcherTest

* docs: Document and trace requirement for identifier clipboard autofocus behavior

* docs: fix Markdown lint errors in focus.md

* refactor: move identifier recognition logic to Identifier.from()

- Moved getIdentifier() from CompositeIdFetcher to Identifier as static factory method 'from(String)'
- Updated all call sites to use Identifier.from(...)

* refactor: use structured check for ISBN fetcher with module export

- Replaced string matching with instanceof IsbnFetcher in NewEntryView
- Exported isbn fetcher package from jablib to enable module access

---------

Co-authored-by: Christoph <[email protected]>

Author: lydia-yan

CHANGELOG.md

@@ -21,6 +21,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added a new button to toggle the file path between an absolute and relative formats in context of library properties. [#13031](https://github.com/JabRef/jabref/issues/13031)
 - We added automatic selection of the “Enter Identifier” tab with pre-filled clipboard content if the clipboard contains a valid identifier when opening the “Create New Entry” dialog. [#13087](https://github.com/JabRef/jabref/issues/13087)
 - We added an "Open example library" button to Welcome Tab. [#13014](https://github.com/JabRef/jabref/issues/13014)
+- We added automatic detection and selection of the identifier type (e.g., DOI, ISBN, arXiv) based on clipboard content when opening the "New Entry" dialog [#13111](https://github.com/JabRef/jabref/pull/13111)
 - We added support for import of a Refer/BibIX file format. [#13069](https://github.com/JabRef/jabref/issues/13069)
 
 ### Changed

docs/requirements/focus.md

@@ -13,4 +13,20 @@ This provides immediate keyboard interaction capabilities (such as Ctrl+V for pa
 
 Needs: impl
 
+### Automatic Identifier Detection and Focus in New Entry Dialog
+`req~newentry.clipboard.autofocus~1`
+
+When the "New Entry" dialog is opened:
+
+- If the clipboard contains a valid identifier (e.g., DOI, ISBN, ArXiv, RFC):
+
+  - The dialog automatically switches to the "Enter Identifier" tab.
+  - The identifier input field is automatically filled with the clipboard content.
+  - The field receives keyboard focus and its content is selected.
+  - The corresponding fetcher (e.g., DOI, ISBN) is automatically selected based on the detected identifier type.
+
+This behavior streamlines the process of creating new entries by allowing users to copy an identifier and open the dialog, without needing to manually select the input field, switch tabs, or choose a fetcher manually.
+
+Needs: impl
+
 <!-- markdownlint-disable-file MD022 -->

jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java

@@ -35,18 +35,25 @@
 import org.jabref.gui.util.UiTaskExecutor;
 import org.jabref.gui.util.ViewModelListCellFactory;
 import org.jabref.logic.ai.AiService;
-import org.jabref.logic.importer.CompositeIdFetcher;
 import org.jabref.logic.importer.IdBasedFetcher;
 import org.jabref.logic.importer.WebFetcher;
+import org.jabref.logic.importer.fetcher.ArXivFetcher;
 import org.jabref.logic.importer.fetcher.DoiFetcher;
+import org.jabref.logic.importer.fetcher.RfcFetcher;
+import org.jabref.logic.importer.fetcher.isbntobibtex.IsbnFetcher;
 import org.jabref.logic.importer.plaincitation.PlainCitationParserChoice;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.util.TaskExecutor;
 import org.jabref.model.database.BibDatabaseMode;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.BibEntryType;
 import org.jabref.model.entry.BibEntryTypesManager;
+import org.jabref.model.entry.identifier.ArXivIdentifier;
+import org.jabref.model.entry.identifier.DOI;
+import org.jabref.model.entry.identifier.ISBN;
 import org.jabref.model.entry.identifier.Identifier;
+import org.jabref.model.entry.identifier.RFC;
+import org.jabref.model.entry.identifier.SSRN;
 import org.jabref.model.entry.types.BiblatexAPAEntryTypeDefinitions;
 import org.jabref.model.entry.types.BiblatexEntryTypeDefinitions;
 import org.jabref.model.entry.types.BiblatexSoftwareEntryTypeDefinitions;
@@ -147,7 +154,7 @@ private void finalizeTabs() {
         if (approach == null) {
             final String clipboardText = ClipBoardManager.getContents().trim();
             if (!StringUtil.isBlank(clipboardText)) {
-                Optional<Identifier> identifier = CompositeIdFetcher.getIdentifier(clipboardText);
+                Optional<Identifier> identifier = Identifier.from(clipboardText);
                 if (identifier.isPresent()) {
                     approach = NewEntryDialogTab.ENTER_IDENTIFIER;
                     interpretText.setText(clipboardText);
@@ -254,14 +261,6 @@ private void initializeLookupIdentifier() {
         idText.setPromptText(Localization.lang("Enter the reference identifier to search for."));
         idText.textProperty().bindBidirectional(viewModel.idTextProperty());
         final String clipboardText = ClipBoardManager.getContents().trim();
-        if (!StringUtil.isBlank(clipboardText) && !clipboardText.contains("\n")) {
-            // :TODO: Better validation would be nice here, so clipboard text is only copied over if it matches a
-            // supported identifier format.
-            idText.setText(clipboardText);
-            idText.selectAll();
-        }
-
-        idLookupGuess.selectedProperty().addListener((_, _, newValue) -> preferences.setIdLookupGuessing(newValue));
 
         ToggleGroup toggleGroup = new ToggleGroup();
         idLookupGuess.setToggleGroup(toggleGroup);
@@ -273,6 +272,23 @@ private void initializeLookupIdentifier() {
             idLookupSpecify.selectedProperty().set(true);
         }
 
+        // [impl->req~newentry.clipboard.autofocus~1]
+        Optional<Identifier> validClipboardId = extractValidIdentifierFromClipboard();
+        if (validClipboardId.isPresent()) {
+            idText.setText(ClipBoardManager.getContents().trim());
+            idText.selectAll();
+
+            Identifier id = validClipboardId.get();
+            Platform.runLater(() -> {
+                idLookupSpecify.setSelected(true);
+                fetcherForIdentifier(id).ifPresent(idFetcher::setValue);
+            });
+        } else {
+            Platform.runLater(() -> idLookupGuess.setSelected(true));
+        }
+
+        idLookupGuess.selectedProperty().addListener((_, _, newValue) -> preferences.setIdLookupGuessing(newValue));
+
         idFetcher.itemsProperty().bind(viewModel.idFetchersProperty());
         new ViewModelListCellFactory<IdBasedFetcher>().withText(WebFetcher::getName).install(idFetcher);
         idFetcher.disableProperty().bind(idLookupSpecify.selectedProperty().not());
@@ -523,4 +539,41 @@ private static PlainCitationParserChoice parserFromName(String parserName, List<
         }
         return null;
     }
+
+    private Optional<Identifier> extractValidIdentifierFromClipboard() {
+        String clipboardText = ClipBoardManager.getContents().trim();
+
+        if (!StringUtil.isBlank(clipboardText) && !clipboardText.contains("\n")) {
+            Optional<Identifier> identifier = Identifier.from(clipboardText);
+            if (identifier.isPresent()) {
+                Identifier id = identifier.get();
+                boolean isValid = switch (id) {
+                    case DOI doi ->
+                            DOI.isValid(doi.asString());
+                    case ISBN isbn ->
+                            isbn.isValid();
+                    default ->
+                            true;
+                };
+                if (isValid) {
+                    return Optional.of(id);
+                }
+            }
+        }
+
+        return Optional.empty();
+    }
+
+    private Optional<IdBasedFetcher> fetcherForIdentifier(Identifier id) {
+        for (IdBasedFetcher fetcher : idFetcher.getItems()) {
+            if ((id instanceof DOI && fetcher instanceof DoiFetcher) ||
+                    (id instanceof ISBN && (fetcher instanceof IsbnFetcher) ||
+                    (id instanceof ArXivIdentifier && fetcher instanceof ArXivFetcher) ||
+                    (id instanceof RFC && fetcher instanceof RfcFetcher) ||
+                    (id instanceof SSRN && fetcher instanceof DoiFetcher))) {
+                return Optional.of(fetcher);
+            }
+        }
+        return Optional.empty();
+    }
 }

jablib/src/main/java/module-info.java

@@ -79,6 +79,7 @@
     exports org.jabref.logic.integrity;
     exports org.jabref.logic.formatter.casechanger;
     exports org.jabref.logic.shared.exception;
+    exports org.jabref.logic.importer.fetcher.isbntobibtex;
     exports org.jabref.logic.importer.fetcher.transformers;
     exports org.jabref.logic.biblog;
     exports org.jabref.model.biblog;

jablib/src/main/java/org/jabref/logic/importer/CompositeIdFetcher.java

@@ -1,8 +1,6 @@
 package org.jabref.logic.importer;
 
 import java.util.Optional;
-import java.util.function.Supplier;
-import java.util.stream.Stream;
 
 import org.jabref.logic.importer.fetcher.ArXivFetcher;
 import org.jabref.logic.importer.fetcher.DoiFetcher;
@@ -15,7 +13,6 @@
 import org.jabref.model.entry.identifier.Identifier;
 import org.jabref.model.entry.identifier.RFC;
 import org.jabref.model.entry.identifier.SSRN;
-import org.jabref.model.strings.StringUtil;
 
 public class CompositeIdFetcher {
 
@@ -67,25 +64,6 @@ public String getName() {
     }
 
     public static boolean containsValidId(String identifier) {
-        return getIdentifier(identifier).isPresent();
-    }
-
-    public static Optional<Identifier> getIdentifier(String identifier) {
-        if (StringUtil.isBlank(identifier)) {
-            return Optional.empty();
-        }
-
-        return Stream.<Supplier<Optional<? extends Identifier>>>of(
-                             () -> DOI.findInText(identifier),
-                             () -> ArXivIdentifier.parse(identifier),
-                             () -> ISBN.parse(identifier),
-                             () -> SSRN.parse(identifier),
-                             () -> RFC.parse(identifier)
-                     )
-                     .map(Supplier::get)
-                     .filter(Optional::isPresent)
-                     .map(Optional::get)
-                     .map(id -> (Identifier) id)
-                     .findFirst();
+        return Identifier.from(identifier).isPresent();
     }
 }

jablib/src/main/java/org/jabref/model/entry/identifier/Identifier.java

@@ -2,8 +2,11 @@
 
 import java.net.URI;
 import java.util.Optional;
+import java.util.function.Supplier;
+import java.util.stream.Stream;
 
 import org.jabref.model.entry.field.Field;
+import org.jabref.model.strings.StringUtil;
 
 /**
  * All implementing classes should additionally offer
@@ -23,4 +26,23 @@ public interface Identifier {
     Field getDefaultField();
 
     Optional<URI> getExternalURI();
+
+    public static Optional<Identifier> from(String identifier) {
+        if (StringUtil.isBlank(identifier)) {
+            return Optional.empty();
+        }
+
+        return Stream.<Supplier<Optional<? extends Identifier>>>of(
+                             () -> DOI.findInText(identifier),
+                             () -> ArXivIdentifier.parse(identifier),
+                             () -> ISBN.parse(identifier),
+                             () -> SSRN.parse(identifier),
+                             () -> RFC.parse(identifier)
+                     )
+                     .map(Supplier::get)
+                     .filter(Optional::isPresent)
+                     .map(Optional::get)
+                     .map(id -> (Identifier) id)
+                     .findFirst();
+    }
 }

jablib/src/test/java/org/jabref/logic/importer/fetcher/CompositeIdFetcherTest.java

@@ -10,17 +10,25 @@
 import org.jabref.model.entry.field.InternalField;
 import org.jabref.model.entry.field.StandardField;
 import org.jabref.model.entry.field.UnknownField;
+import org.jabref.model.entry.identifier.ArXivIdentifier;
+import org.jabref.model.entry.identifier.DOI;
+import org.jabref.model.entry.identifier.ISBN;
+import org.jabref.model.entry.identifier.Identifier;
+import org.jabref.model.entry.identifier.RFC;
 import org.jabref.model.entry.types.StandardEntryType;
 import org.jabref.testutils.category.FetcherTest;
 
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.Answers;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -127,4 +135,41 @@ void performSearchByIdReturnsEmptyForInvalidId(String groundInvalidArXivId) thro
     void performSearchByIdReturnsCorrectEntryForIdentifier(String name, BibEntry bibEntry, String identifier) throws FetcherException {
         assertEquals(Optional.of(bibEntry), compositeIdFetcher.performSearchById(identifier));
     }
+
+    @Test
+    void detectsValidDOI() {
+        Optional<Identifier> result = Identifier.from("10.1109/MCOM.2010.5673082");
+        assertTrue(result.isPresent());
+        assertInstanceOf(DOI.class, result.get());
+        assertTrue(DOI.isValid(result.get().asString()));
+    }
+
+    @Test
+    void rejectsInvalidDOI() {
+        Optional<Identifier> result = Identifier.from("123456789");
+        boolean isInvalid = result.isEmpty() || (result.get() instanceof DOI && !DOI.isValid(result.get().asString()));
+        assertTrue(isInvalid);
+    }
+
+    @Test
+    void detectsValidISBN() {
+        Optional<Identifier> result = Identifier.from("9780134685991");
+        assertTrue(result.isPresent());
+        assertInstanceOf(ISBN.class, result.get());
+        assertTrue(((ISBN) result.get()).isValid());
+    }
+
+    @Test
+    void detectsValidArXiv() {
+        Optional<Identifier> result = Identifier.from("arXiv:1706.03762");
+        assertTrue(result.isPresent());
+        assertInstanceOf(ArXivIdentifier.class, result.get());
+    }
+
+    @Test
+    void detectsValidRFC() {
+        Optional<Identifier> result = Identifier.from("rfc2616");
+        assertTrue(result.isPresent());
+        assertInstanceOf(RFC.class, result.get());
+    }
 }