Fix JabRef-post-image.wsf to make it agnostic to the location of the …

[alexeysemenyukoracle]

Fix JabRef-post-image.wsf script to make it independent of the project build location.

Build-only change to eliminate dependencies on the context in which the "post-image" jpackage script is called on Windows.

Closes #13034

Important: the baseline for the fix is v6.0-alpha2 tag. There is no JabRef-post-image.wsf in the main branch after #12990, so this PR can not be integrated as-is.

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
• [/] Tests created for changes (if applicable)
• [/] Manually tested changed features in running JabRef (always required)
• [/] Screenshots added in PR description (if change is visible to the user)
• [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

Thanks for the contribution! Looks good from my side. Would you please resolce the conflicts then we can merge it!

[Siedlerchr]

Due to the modularization which we merged after the alpha, the jpackage resources are now under jabgui/buildres/windows and in the corresponding build gradle file.

[alexeysemenyukoracle]

Right, but there is no JabRef-post-image.wsf script in these resources anymore. Instead, there is "main.wxs". If this is a permanent fix and not a temporary workaround for jpackage's bug in JDK24, then this pull request can be discarded. Otherwise, I can merge and integrate it later.

[Siedlerchr]

I totally overlooked that it was integrated into the main.wxs now. I think it was originally meant to be a workaround by @koppor but could be a permanent solution now as well if it works as intended.

[koppor]

I think, we should get this in. The idea of the script was IMHO: Take the JDK generated main.w... file as "leading X and add necessary things afterwards.

I will try to take care later.

(And @alexeysemenyukoracle thank you so much for the time invested!)

[koppor]

As far as I understood openjdk/jdk#19318 (comment) and https://bugs.openjdk.org/browse/JDK-8355651, we should update to JDK25 to have the script working again? 😅

[koppor]

Blocked by:

• gradle not supporting JDK EA builds for toolhcain: Support JDK EA versions for toolchain downloads gradle/gradle#14814
• gradle not supporting Java 25 at all: Support compiling and testing on Java 25 gradle/gradle#33310

---

Debugging more:

• JDK 25 is available on the DISCO API: https://api.foojay.io/swagger-ui#/default/getDistributionV3
• I cannot convince gradle to resolve that: Duplicate configuration for repository 'foojay'. gradle/foojay-toolchains#109
• Trying with mise to install JDK-EA: Java release type setting not honored? jdx/mise#2991 (reply in thread)

---

Wishes:

• Add support for mise locations. gradle/foojay-toolchains#110 be implemented
• Auto-detection of installed toolchains by mise gradle/gradle#29355 be implemented

[koppor]

Windows:

> Could not copy file 'D:\a\jabref\jabref\jabgui\buildres\windows\JabRef-post-image.wsf' to 'D:\a\jabref\jabref\jabgui\build\jpackage-resource-dir\JabRef-post-image.wsf'.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
   > Error - Invalid filter specification for org.apache.tools.ant.filters.ReplaceTokens

The ChatGPT-solution (dc293db) seems to be wired... Needs more investigation.

[alexeysemenyukoracle]

I'd stick to the current workaround with "main.wxs" and revisit this PR later when you decide to migrate to a newer JDK version.

[koppor]

I merged upstream/main (and resolved conflicts). CI shows

 > Could not copy file 'D:\a\jabref\jabref\jabgui\buildres\windows\JabRef-post-image.wsf' to 'D:\a\jabref\jabref\jabgui\build\jpackage-resource-dir\JabRef-post-image.wsf'.

   > Error - Invalid filter specification for org.apache.tools.ant.filters.ReplaceTokens
[Incubating] Problems report is available at: file:///D:/a/jabref/jabref/build/reports/problems/problems-report.html

Too late here for a proper-follow-up now. 😅

[trag-bot]

@trag-bot didn't find any issues in the code! ✅✨

[calixtus]

Refs #14057

[koppor]

Note that this is blocked by JDK-8358723, which is about broken signing of macOS binaries.