Skip to content

Area of preview on hover should be shrink to the size of the text displayed #13555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Area of preview on hover should be shrink to the size of the text displayed #13555

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
202af9c
Initial fix
xIshanSandhux Jul 18, 2025
eda59fb
Update MainTableTooltip.java
xIshanSandhux Jul 18, 2025
6d6fd96
got the width based on the text
xIshanSandhux Jul 19, 2025
a24adc8
Apply suggestion from code review
koppor Jul 28, 2025
875b1b2
fixed width for the hover
xIshanSandhux Aug 2, 2025
2d4ff2a
fixed height and hid the scroll bars
xIshanSandhux Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jabgui/src/main/java/org/jabref/gui/maintable/MainTableTooltip.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public MainTableTooltip(DialogService dialogService, GuiPreferences preferences,
this.preferences = preferences;
this.preview = new PreviewViewer(dialogService, preferences, themeManager, taskExecutor);
this.tooltipContent.getChildren().addAll(fieldValueLabel, preview);
this.preview.setMinHeight(200);
}

public Tooltip createTooltip(BibDatabaseContext databaseContext, BibEntry entry, String fieldValue) {
Expand Down
20 changes: 20 additions & 0 deletions jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
import java.net.MalformedURLException;
import java.util.List;
import java.util.Objects;
import java.util.concurrent.atomic.AtomicBoolean;

import javafx.application.Platform;
import javafx.beans.InvalidationListener;
import javafx.beans.Observable;
import javafx.beans.property.SimpleStringProperty;
Expand Down Expand Up @@ -52,6 +54,7 @@
public class PreviewViewer extends ScrollPane implements InvalidationListener {

private static final Logger LOGGER = LoggerFactory.getLogger(PreviewViewer.class);
AtomicBoolean widthSet = new AtomicBoolean(false);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the empty line as the thing which follow these multiple lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

// https://stackoverflow.com/questions/5669448/get-selected-texts-html-in-div/5670825#5670825
private static final String JS_GET_SELECTION_HTML_SCRIPT = """
Expand Down Expand Up @@ -125,6 +128,23 @@ private void configurePreviewView(ThemeManager themeManager) {
return;
}

Platform.runLater(() -> {
if (previewView.getEngine().executeScript("document.getElementById('content').scrollHeight") instanceof java.lang.Number heightVal) {
double actualHeight = (heightVal).doubleValue();
LOGGER.debug("Preview Height {}", actualHeight);
previewView.setPrefHeight(actualHeight + 4);
}

if (previewView.getEngine().executeScript("document.getElementById('content').scrollWidth") instanceof java.lang.Number widthVal && !widthSet.get()) {
double actualWidth = (widthVal).doubleValue();
double updatedWidth = actualWidth + 310;

LOGGER.debug("Preview Width {}", actualWidth);
previewView.setPrefWidth(Math.min(updatedWidth, 500));
widthSet.set(true);
}
});

// https://stackoverflow.com/questions/15555510/javafx-stop-opening-url-in-webview-open-in-browser-instead
NodeList anchorList = previewView.getEngine().getDocument().getElementsByTagName("a");
for (int i = 0; i < anchorList.getLength(); i++) {
Expand Down
Loading