-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[Junie]: fix: resolve IllegalArgumentException for non-absolute URIs #13669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Siedlerchr
merged 5 commits into
main
from
jetbrains-junie/issue-12186-run-fd7e881f-15c2-437d-a291-ced0190b26f1
Aug 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6a5dd9a
fix: resolve IllegalArgumentException for non-absolute URIs
jetbrains-junie[bot] 89c3019
[issue-13669] test(FileFieldParserTest): add test for URL handling wiβ¦
junie-eap[bot] 919b203
Merge branch 'main' into jetbrains-junie/issue-12186-run-fd7e881f-15cβ¦
Siedlerchr 8631698
[issue-13669] fix: resolve IllegalArgumentException for www. URLs
junie-eap[bot] 41f9feb
fix
Siedlerchr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,9 +118,18 @@ void emptyUrl() { | |
} | ||
|
||
@Test | ||
void uriMissingScheme() { | ||
void urlStartingWithWww() throws MalformedURLException { | ||
// URLs starting with www. should be prefixed with http:// | ||
URL result = URLUtil.create("www.example.com"); | ||
assertNotNull(result); | ||
assertEquals("http://www.example.com", result.toString()); | ||
} | ||
|
||
@Test | ||
void uriMissingSchemeAndNotStartingWithWww() { | ||
// URLs not starting with www. and without a scheme should still throw an exception | ||
MalformedURLException exception = assertThrows(MalformedURLException.class, () -> | ||
URLUtil.create("www.example.com")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep the existin test - only add new ones @jetbrains-junie |
||
URLUtil.create("example.com")); | ||
assertTrue(exception.getMessage().contains("not absolute")); | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to https - we have 2025 with http severywhere. @jetbrains-junie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to https - we have 2025 with http severywhere. https://github.com/jetbrains-junie