-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add more walkthroughs, donation prompt, and responsive layout for welcome tab #13679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
06ec2cb
Add "Add Group" walkthrough, tweak quick settings, and tweak welcome tab
Yubo-Cao adcb443
Refactor search modifier buttons to bind bidirectionally with SearchP…
Yubo-Cao bcb08af
Fix issue with repeated localization
Yubo-Cao 66248ae
Add donation popup in WelcomeTab
Yubo-Cao 235b815
Add search walkthrough and responsive layout for WelcomeTab
Yubo-Cao 54b5a03
Additional fix to responsive layout
Yubo-Cao 25eb89f
Fix walkthrough color
Yubo-Cao 7aa6c28
Update CHANGELOG.md
Yubo-Cao 4e8633a
Small tweaaks to Walkthroughs
Yubo-Cao 8396fd0
Add search walkthrough and responsive layout for WelcomeTab
Yubo-Cao e7c27fc
Additional fix to responsive layout
Yubo-Cao f2ff8be
Fix walkthrough color
Yubo-Cao 0820579
Update CHANGELOG.md
Yubo-Cao 7df9b4a
Small tweaaks to Walkthroughs
Yubo-Cao df6862d
merge: branch 'more-walkthroughes' of https://github.com/Yubo-Cao/jab…
Yubo-Cao 82b8f24
test(donation): Add test to DonationProvider and refactored the displ…
Yubo-Cao c835d10
fix(donation): Applied all the suggested changes
Yubo-Cao a84fc33
test(donation): Apply open rewrite
Yubo-Cao bacb5e8
merge: remote-tracking branch 'upstream/main' into more-walkthroughes
Yubo-Cao 28d6c3b
test(donation): Use appropriate mock parameters for testing
Yubo-Cao dc249d2
fix(donation): Fix imports in GuiPreferences
Yubo-Cao 174f62d
style: Remove extra newlines at end of new walkthroughs and donations
Yubo-Cao b12af73
merge: remote-tracking branch 'upstream/main' into more-walkthroughes
Yubo-Cao b55db22
fix: update according to Subhramit and Carl's suggestion
Yubo-Cao f8f48af
fix: fix the GlobalSearchBarTest
Yubo-Cao a3346f9
Merge branch 'main' into more-walkthroughes
Yubo-Cao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
jabgui/src/main/java/org/jabref/gui/preferences/DonationPreferences.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package org.jabref.gui.preferences; | ||
|
||
import javafx.beans.property.BooleanProperty; | ||
import javafx.beans.property.IntegerProperty; | ||
import javafx.beans.property.SimpleBooleanProperty; | ||
import javafx.beans.property.SimpleIntegerProperty; | ||
|
||
public class DonationPreferences { | ||
private final BooleanProperty neverShowAgain = new SimpleBooleanProperty(); | ||
private final IntegerProperty lastShownEpochDay = new SimpleIntegerProperty(); | ||
|
||
public DonationPreferences(boolean neverShowAgain, int lastShownEpochDay) { | ||
this.neverShowAgain.set(neverShowAgain); | ||
this.lastShownEpochDay.set(lastShownEpochDay); | ||
} | ||
|
||
public boolean isNeverShowAgain() { | ||
return neverShowAgain.get(); | ||
} | ||
|
||
public void setNeverShowAgain(boolean value) { | ||
this.neverShowAgain.set(value); | ||
} | ||
|
||
public BooleanProperty neverShowAgainProperty() { | ||
return neverShowAgain; | ||
} | ||
|
||
public int getLastShownEpochDay() { | ||
return lastShownEpochDay.get(); | ||
} | ||
|
||
public void setLastShownEpochDay(int value) { | ||
this.lastShownEpochDay.set(value); | ||
} | ||
|
||
public IntegerProperty lastShownEpochDayProperty() { | ||
return lastShownEpochDay; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.