Skip to content

Conversation

SalvadorRomo
Copy link
Contributor

@SalvadorRomo SalvadorRomo commented Aug 11, 2025

Closes #12967

This PR fix the issue when a new entry is added from the cited by tab and that new entry type is modifidied , then it gets deselected from the cited By , in the original entry that was selected.

Next steps:

  • define if this is the right approach. Right now we don't know if this the right solution, because eliminating this validation seems dubious.
  • Additional step to implement is disabled entry to be modified manually, this way, information continue being compliant with fetched one

Steps to test

  • Add a new entry.
  • from the entry added, go to the citations relation ,cited by tab and selected a new entry.
  • In the library, select the recently added entry, and go to BibTex Soruce Tab.
  • if the entry is Misc, change it manually for Article
  • Now, with this change, the entry will continue being selected even though the type change

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@jabref-machine
Copy link
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

Copy link

trag-bot bot commented Aug 11, 2025

@trag-bot didn't find any issues in the code! ✅✨

@jabref-machine
Copy link
Collaborator

JUnit tests of jablib are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test cases to show the behavior. Then we can think if this is the right solution.

@@ -337,8 +337,7 @@ public boolean isDuplicate(final BibEntry one, final BibEntry two, final BibData
}

// TODO: Work on haveDifferentEntryType - InCollection and InProceedings could point to the same publication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove this line, too.

@calixtus
Copy link
Member

Hi, are you planning to continue your work on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citation relations tab doesn't work properly!
4 participants