Skip to content

Manual code reformattings #13883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2025
Merged

Manual code reformattings #13883

merged 3 commits into from
Sep 13, 2025

Conversation

@koppor
Copy link
Member

@koppor koppor commented Sep 13, 2025 •
edited
Loading

This ports the manual changes of #13872 to a separate PR - to prepare a new formatting.

Pre-condition for: #13883

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

This was referenced Sep 13, 2025
Merged
Merged
@koppor koppor marked this pull request as ready for review September 13, 2025 17:13
Siedlerchr
Siedlerchr reviewed Sep 13, 2025
View reviewed changes
.jbang/CheckoutPR.java
// We use "contains", because there could be SSH remote URLs
.filter(r -> r.getURIs().stream().anyMatch(uri -> uri.toString().contains("JabRef/jabref")))
.findFirst();
// We use "contains", because there could be SSH remote URLs
Copy link
Member

@Siedlerchr Siedlerchr Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Eclipse did this I was hit by Olly and others to revert this...

Copy link
Member

@subhramit subhramit Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor does this need revert?

Copy link
Member Author

@koppor koppor Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - when touching the code, we can move remotes.stream() to the next line to have the dots properly aligned.

@subhramit subhramit merged commit 53acc92 into main Sep 13, 2025
37 checks passed
@subhramit subhramit deleted the fix-code-style branch September 13, 2025 17:15
Siedlerchr added a commit that referenced this pull request Sep 14, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
e0909e6 
* upstream/main:
  Add hint on auto formatting (#13886)
  Add ADR-0050 on code formatter (#13895)
  Reformat codebase (more carefully) (#13885)
  New Crowdin updates (#13892)
  Fix record wrapping (#13889)
  Fix JavaDoc (#13888)
  Improve IntelliJ settings (#13887)
  Manual code reformattings (#13883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@subhramit subhramit subhramit approved these changes

Assignees

No one assigned

Labels

project: jabcon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koppor @Siedlerchr @subhramit