Reformat codebase (more carefully)

build-support/src/main/java/CitationStyleCatalogGenerator.java

@@ -1,5 +1,3 @@
-///usr/bin/env jbang "$0" "$@" ; exit $?
-
 //JAVA 24
 //RUNTIME_OPTIONS --enable-native-access=ALL-UNNAMED
 

build-support/src/main/java/JournalListMvGenerator.java

@@ -1,5 +1,3 @@
-///usr/bin/env jbang "$0" "$@" ; exit $?
-
 //JAVA 24
 //RUNTIME_OPTIONS --enable-native-access=ALL-UNNAMED
 
@@ -44,7 +42,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-
 /// Has to be started in the root of the repository due to <https://github.com/jbangdev/jbang-gradle-plugin/issues/11>
 public class JournalListMvGenerator {
 

build-support/src/main/java/LtwaListMvGenerator.java

@@ -1,5 +1,3 @@
-///usr/bin/env jbang "$0" "$@" ; exit $?
-
 //JAVA 24
 //RUNTIME_OPTIONS --enable-native-access=ALL-UNNAMED
 

config/IntelliJ Code Style.xml

@@ -3,7 +3,9 @@
   <option name="SOFT_MARGINS" value="120" />
   <option name="DO_NOT_FORMAT">
     <list>
-      <fileSet type="globPattern" pattern=".jbang/*.java" />
+        <fileSet type="globPattern" pattern=".jbang/*.java" />
+        <fileSet type="globPattern" pattern="AutoCompletionTextInputBinding.java" />
+        <fileSet type="globPattern" pattern="SuggestionProvider.java" />
     </list>
   </option>
   <JavaCodeStyleSettings>
@@ -304,4 +306,4 @@
       </rules>
     </arrangement>
   </codeStyleSettings>
-</code_scheme>
+</code_scheme>

jabgui/src/main/java/org/jabref/Launcher.java

@@ -110,8 +110,8 @@ public static void initLogging(String[] args) {
         // We must configure logging as soon as possible, which is why we cannot wait for the usual
         // argument parsing workflow to parse logging options e.g. --debug
         Level logLevel = Arrays.stream(args).anyMatch("--debug"::equalsIgnoreCase)
-                ? Level.DEBUG
-                : Level.INFO;
+                         ? Level.DEBUG
+                         : Level.INFO;
 
         // addLogToDisk
         // We cannot use `Injector.instantiateModelOrService(BuildInfo.class).version` here, because this initializes logging

jabgui/src/main/java/org/jabref/cli/CliImportHelper.java

@@ -30,8 +30,8 @@ public class CliImportHelper {
      * @param location URL or file path to import
      */
     public static Optional<ParserResult> importFile(String location,
-                                             CliPreferences cliPreferences,
-                                             boolean porcelain) {
+                                                    CliPreferences cliPreferences,
+                                                    boolean porcelain) {
         LOGGER.debug("Importing file from locaiton {}", location);
         String[] data = location.split(",");
 
@@ -42,7 +42,7 @@ public static Optional<ParserResult> importFile(String location,
             try {
                 file = new URLDownload(address).toTemporaryFile();
             } catch (FetcherException |
-                    MalformedURLException e) {
+                     MalformedURLException e) {
                 System.err.println(Localization.lang("Problem downloading from %0: %1", address, e.getLocalizedMessage()));
                 return Optional.empty();
             }
@@ -63,9 +63,9 @@ public static Optional<ParserResult> importFile(String location,
         return importResult;
     }
 
-   public static Optional<ParserResult> importFile(Path file,
-                                             CliPreferences cliPreferences,
-                                             boolean porcelain) {
+    public static Optional<ParserResult> importFile(Path file,
+                                                    CliPreferences cliPreferences,
+                                                    boolean porcelain) {
         try {
             ImportFormatReader importFormatReader = new ImportFormatReader(
                     cliPreferences.getImporterPreferences(),

jabgui/src/main/java/org/jabref/gui/JabRefDialogService.java

@@ -446,23 +446,23 @@ public void notify(String message) {
         LOGGER.info(message);
 
         UiTaskExecutor.runInJavaFXThread(() ->
-            Notifications.create()
-                         .text(message)
-                         .position(Pos.BOTTOM_CENTER)
-                         .hideAfter(TOAST_MESSAGE_DISPLAY_TIME)
-                         .owner(mainWindow)
-                         .threshold(5,
-                            Notifications.create()
-                                         .title(Localization.lang("Last notification"))
-                                         .text(
-                                            "(" + Localization.lang("Check the event log to see all notifications") + ")"
-                                            + "\n\n" + message)
-                                         .onAction(e -> {
-                                            ErrorConsoleAction ec = new ErrorConsoleAction();
-                                            ec.execute();
-                                         }))
-                         .hideCloseButton()
-                         .show());
+                Notifications.create()
+                             .text(message)
+                             .position(Pos.BOTTOM_CENTER)
+                             .hideAfter(TOAST_MESSAGE_DISPLAY_TIME)
+                             .owner(mainWindow)
+                             .threshold(5,
+                                     Notifications.create()
+                                                  .title(Localization.lang("Last notification"))
+                                                  .text(
+                                                          "(" + Localization.lang("Check the event log to see all notifications") + ")"
+                                                                  + "\n\n" + message)
+                                                  .onAction(e -> {
+                                                      ErrorConsoleAction ec = new ErrorConsoleAction();
+                                                      ec.execute();
+                                                  }))
+                             .hideCloseButton()
+                             .show());
     }
 
     @Override

jabgui/src/main/java/org/jabref/gui/JabRefGUI.java

@@ -326,7 +326,7 @@ public void onShowing(WindowEvent event) {
 
         // Open last edited databases
         if (uiCommands.stream().noneMatch(UiCommand.BlankWorkspace.class::isInstance)
-            && preferences.getWorkspacePreferences().shouldOpenLastEdited()) {
+                && preferences.getWorkspacePreferences().shouldOpenLastEdited()) {
             mainFrame.openLastEditedDatabases();
         }
 

jabgui/src/main/java/org/jabref/gui/LibraryTab.java

@@ -53,7 +53,7 @@
 import org.jabref.gui.maintable.MainTableDataModel;
 import org.jabref.gui.preferences.GuiPreferences;
 import org.jabref.gui.undo.CountingUndoManager;
-import org.jabref.gui.undo.NamedCompound;
+import org.jabref.gui.undo.NamedCompoundEdit;
 import org.jabref.gui.undo.UndoableFieldChange;
 import org.jabref.gui.undo.UndoableInsertEntries;
 import org.jabref.gui.undo.UndoableRemoveEntries;
@@ -123,7 +123,6 @@ public class LibraryTab extends Tab implements CommandSelectionTab {
     private final BooleanProperty canGoForwardProperty = new SimpleBooleanProperty(false);
     private boolean backOrForwardNavigationActionTriggered = false;
 
-
     private BibDatabaseContext bibDatabaseContext;
 
     // All subscribers needing "coarse" change events should use this filter
@@ -210,8 +209,8 @@ private LibraryTab(@NonNull BibDatabaseContext bibDatabaseContext,
 
         stateManager.activeDatabaseProperty().addListener((_, _, _) -> {
             if (preferences.getSearchPreferences().isFulltext()) {
-              mainTable.getTableModel().refreshSearchMatches();
-           }
+                mainTable.getTableModel().refreshSearchMatches();
+            }
         });
     }
 
@@ -466,13 +465,13 @@ public SuggestionProviders getSuggestionProviders() {
     }
 
     public void registerUndoableChanges(List<FieldChange> changes) {
-        NamedCompound ce = new NamedCompound(Localization.lang("Save actions"));
+        NamedCompoundEdit compoundEdit = new NamedCompoundEdit(Localization.lang("Save actions"));
         for (FieldChange change : changes) {
-            ce.addEdit(new UndoableFieldChange(change));
+            compoundEdit.addEdit(new UndoableFieldChange(change));
         }
-        ce.end();
-        if (ce.hasEdits()) {
-            getUndoManager().addEdit(ce);
+        compoundEdit.end();
+        if (compoundEdit.hasEdits()) {
+            getUndoManager().addEdit(compoundEdit);
         }
     }
 
@@ -1025,7 +1024,7 @@ public void updateNavigationState() {
      * Creates a new library tab. Contents are loaded by the {@code dataLoadingTask}. Most of the other parameters are required by {@code resetChangeMonitor()}.
      *
      * @param dataLoadingTask The task to execute to load the data asynchronously.
-     * @param file the path to the file (loaded by the dataLoadingTask)
+     * @param file            the path to the file (loaded by the dataLoadingTask)
      */
     public static LibraryTab createLibraryTab(BackgroundTask<ParserResult> dataLoadingTask,
                                               Path file,

jabgui/src/main/java/org/jabref/gui/ai/components/aichat/AiChatComponent.java

@@ -95,8 +95,8 @@ public AiChatComponent(AiService aiService,
         aiService.getIngestionService().ingest(name, ListUtil.getLinkedFiles(entries).toList(), bibDatabaseContext);
 
         ViewLoader.view(this)
-                .root(this)
-                .load();
+                  .root(this)
+                  .load();
     }
 
     @FXML
@@ -215,10 +215,11 @@ private List<Notification> updateNotificationsForEntry(BibEntry entry) {
 
         entry.getFiles().stream().map(file -> aiService.getIngestionService().ingest(file, bibDatabaseContext)).forEach(ingestionStatus -> {
             switch (ingestionStatus.getState()) {
-                case PROCESSING -> notifications.add(new Notification(
-                    Localization.lang("File %0 is currently being processed", ingestionStatus.getObject().getLink()),
-                    Localization.lang("After the file is ingested, you will be able to chat with it.")
-                ));
+                case PROCESSING ->
+                        notifications.add(new Notification(
+                                Localization.lang("File %0 is currently being processed", ingestionStatus.getObject().getLink()),
+                                Localization.lang("After the file is ingested, you will be able to chat with it.")
+                        ));
 
                 case ERROR -> {
                     assert ingestionStatus.getException().isPresent(); // When the state is ERROR, the exception must be present.
@@ -229,7 +230,8 @@ private List<Notification> updateNotificationsForEntry(BibEntry entry) {
                     ));
                 }
 
-                case SUCCESS -> { }
+                case SUCCESS -> {
+                }
             }
         });
 

jabgui/src/main/java/org/jabref/gui/ai/components/aichat/chatprompt/ChatPromptComponent.java

@@ -127,9 +127,9 @@ private void initialize() {
                     // The easy way to get rid of this ambiguity is to disallow scrolling when there are new lines in the prompt.
                     // But the exception to this situation is when the caret position is at the beginning of the prompt.
                     history.get().stream()
-                            .skip(newValue.intValue())
-                            .findFirst()
-                            .ifPresent(message -> userPromptTextArea.setText(message));
+                           .skip(newValue.intValue())
+                           .findFirst()
+                           .ifPresent(message -> userPromptTextArea.setText(message));
                 }
             } else {
                 // When currentUserMessageScroll is set to NEW_NON_EXISTENT_MESSAGE, then we should:

jabgui/src/main/java/org/jabref/gui/ai/components/util/notifications/Notification.java

@@ -9,4 +9,5 @@
  * about possible problems with entries (because that will affect LLM output), but on the other hand the user would
  * like to chat with all available entries in the group, even if some of them are not valid.
  */
-public record Notification(String title, String message) { }
+public record Notification(String title, String message) {
+}

jabgui/src/main/java/org/jabref/gui/autocompleter/PersonNameStringConverter.java

@@ -41,7 +41,8 @@ public PersonNameStringConverter(AutoCompletePreferences preferences) {
     public String toString(Author author) {
         if (autoCompLF) {
             switch (autoCompleteFirstNameMode) {
-                case ONLY_ABBREVIATED, BOTH:
+                case ONLY_ABBREVIATED,
+                     BOTH:
                     return author.getFamilyGiven(true);
                 case ONLY_FULL:
                     return author.getFamilyGiven(false);
@@ -51,7 +52,8 @@ public String toString(Author author) {
         }
         if (autoCompFF) {
             switch (autoCompleteFirstNameMode) {
-                case ONLY_ABBREVIATED, BOTH:
+                case ONLY_ABBREVIATED,
+                     BOTH:
                     return author.getGivenFamily(true);
                 case ONLY_FULL:
                     return author.getGivenFamily(false);

jabgui/src/main/java/org/jabref/gui/autosaveandbackup/AutosaveManager.java

@@ -44,8 +44,8 @@ private AutosaveManager(BibDatabaseContext bibDatabaseContext, CoarseChangeFilte
         this.executor.scheduleAtFixedRate(
                 () -> {
                     if (needsSave) {
-                       eventBus.post(new AutosaveEvent());
-                       needsSave = false;
+                        eventBus.post(new AutosaveEvent());
+                        needsSave = false;
                     }
                 },
                 DELAY_BETWEEN_AUTOSAVE_ATTEMPTS_IN_SECONDS,

jabgui/src/main/java/org/jabref/gui/autosaveandbackup/BackupManager.java

@@ -137,11 +137,10 @@ public static void shutdown(BibDatabaseContext bibDatabaseContext, Path backupDi
     /**
      * Checks whether a backup file exists for the given database file. If it exists, it is checked whether it is
      * newer and different from the original.
-     *
+     * <p>
      * In case a discarded file is present, the method also returns <code>false</code>, See also {@link #discardBackup(Path)}.
      *
      * @param originalPath Path to the file a backup should be checked for. Example: jabref.bib.
-     *
      * @return <code>true</code> if backup file exists AND differs from originalPath. <code>false</code> is the
      * "default" return value in the good case. In case a discarded file exists, <code>false</code> is returned, too.
      * In the case of an exception <code>true</code> is returned to ensure that the user checks the output.
@@ -303,7 +302,7 @@ private static Path determineDiscardedFile(Path file, Path backupDir) {
 
     /**
      * Marks the backups as discarded.
-     *
+     * <p>
      * We do not delete any files, because the user might want to recover old backup files.
      * Therefore, we mark discarded backups by a --discarded file.
      */
@@ -340,11 +339,11 @@ private void startBackupTask(Path backupDir) {
         fillQueue(backupDir);
 
         executor.scheduleAtFixedRate(
-                                     // We need to determine the backup path on each action, because we use the timestamp in the filename
-                                     () -> determineBackupPathForNewBackup(backupDir).ifPresent(this::performBackup),
-                                     DELAY_BETWEEN_BACKUP_ATTEMPTS_IN_SECONDS,
-                                     DELAY_BETWEEN_BACKUP_ATTEMPTS_IN_SECONDS,
-                                     TimeUnit.SECONDS);
+                // We need to determine the backup path on each action, because we use the timestamp in the filename
+                () -> determineBackupPathForNewBackup(backupDir).ifPresent(this::performBackup),
+                DELAY_BETWEEN_BACKUP_ATTEMPTS_IN_SECONDS,
+                DELAY_BETWEEN_BACKUP_ATTEMPTS_IN_SECONDS,
+                TimeUnit.SECONDS);
     }
 
     private void fillQueue(Path backupDir) {
@@ -370,7 +369,7 @@ private void fillQueue(Path backupDir) {
      * Unregisters the BackupManager from the eventBus of {@link BibDatabaseContext}.
      * This method should only be used when closing a database/JabRef in a normal way.
      *
-     * @param backupDir The backup directory
+     * @param backupDir    The backup directory
      * @param createBackup If the backup manager should still perform a backup
      */
     private void shutdown(Path backupDir, boolean createBackup) {

jabgui/src/main/java/org/jabref/gui/auximport/NewSubLibraryAction.java

@@ -9,7 +9,7 @@
 
 /**
  * The action concerned with generate a new (sub-)database from latex AUX file.
- *
+ * <p>
  * A new library is created by {@link org.jabref.gui.importer.NewDatabaseAction}
  */
 public class NewSubLibraryAction extends SimpleCommand {