Skip to content

ESC closes the preferences dialog when editing table. #14106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+14 −0
Open

ESC closes the preferences dialog when editing table. #14106

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae51634
Change preferences dialog behaviour so esc key press is not consumed …
Callum-Higginson Oct 19, 2025
2a244a3
WIP: local changes before rebase
u7663368 Oct 19, 2025
53bdb65
Merge branch 'main' into fix-for-issue-8888
subhramit Oct 20, 2025
026b018
Changes in the fix
u7663368 Oct 25, 2025
287680d
Merge branch 'fix-for-issue-8888' of https://github.com/VishakhaMathu…
u7663368 Oct 25, 2025
ff149a1
added changes in the code
u7663368 Oct 25, 2025
c36c778
Merge remote-tracking branch 'origin/main' into fix-for-issue-8888
Callum-Higginson Oct 25, 2025
5b3eb1f
Fix submodules
Callum-Higginson Oct 25, 2025
f3b56cb
Merge branch 'main' into fix-for-issue-8888
Siedlerchr Nov 5, 2025
6fc48b4
add changelog
Siedlerchr Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions jabgui/src/main/java/org/jabref/gui/preferences/PreferencesDialogView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
import javafx.scene.control.ButtonType;
import javafx.scene.control.ListView;
import javafx.scene.control.ScrollPane;
import javafx.scene.control.TableView;
import javafx.scene.control.ToggleButton;
import javafx.scene.control.TreeTableView;
import javafx.scene.control.TreeView;
import javafx.scene.input.KeyCode;
import javafx.scene.input.KeyEvent;

import org.jabref.gui.DialogService;
import org.jabref.gui.icon.IconTheme;
Expand Down Expand Up @@ -93,6 +97,14 @@ private void initialize() {
preferencesContainer.setContent(preferencesTab.getBuilder());
preferencesTab.prefWidthProperty().bind(preferencesContainer.widthProperty().subtract(10d));
preferencesTab.getStyleClass().add("preferencesTab");
this.getDialogPane().addEventFilter(KeyEvent.KEY_PRESSED, event -> {
if (preferences.getKeyBindingRepository().checkKeyCombinationEquality(KeyBinding.CLOSE, event)) {
if (event.getTarget() instanceof ListView || event.getTarget() instanceof TableView || event.getTarget() instanceof TreeView || event.getTarget() instanceof TreeTableView) {
this.closeDialog();
event.consume();
}
}
});
} else {
preferencesContainer.setContent(null);
}
Expand Down
Loading