Skip to content

Convert fixed-value ComboBoxes to SearchableComboBox (#14083) #14165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −14
Open

Convert fixed-value ComboBoxes to SearchableComboBox (#14083) #14165

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0905897
Convert fixed-value ComboBoxes to SearchableComboBox (#14083)
CodeRishiX Oct 22, 2025
11a0ad4
Move SearchableComboBox changelog entry to Unreleased section
CodeRishiX Oct 25, 2025
8a9adca
Fix CHANGELOG.md formatting - remove extra blank lines
CodeRishiX Oct 25, 2025
c8aee9b
Set editable=false for pushToApplicationCombo as suggested
CodeRishiX Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
- We added an option to choose the group during import of the entry(s). [#9191](https://github.com/JabRef/jabref/issues/9191)
- We added an option to search and filter the fields and formatters in the Clean up entries dialog. [#13890](https://github.com/JabRef/jabref/issues/13890)
- We added support for managing multiple linked files via the entry context menu. [#12567](https://github.com/JabRef/jabref/issues/12567)
- We changed fixed-value ComboBoxes to SearchableComboBox for better usability. [#14083](https://github.com/JabRef/jabref/issues/14083)

### Changed

Expand Down
6 changes: 3 additions & 3 deletions jabgui/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import javafx.beans.value.ObservableBooleanValue;
import javafx.css.PseudoClass;
import javafx.scene.control.Button;
import javafx.scene.control.ComboBox;
import javafx.scene.control.TextField;
import javafx.scene.control.Tooltip;
import javafx.scene.input.KeyCode;
Expand All @@ -27,6 +26,7 @@
import org.jabref.logic.l10n.Localization;

import com.tobiasdiez.easybind.EasyBind;
import org.controlsfx.control.SearchableComboBox;

public class WebSearchPaneView extends VBox {

Expand Down Expand Up @@ -84,8 +84,8 @@ private void addQueryValidationHints(TextField query) {
/**
* Create combo box for selecting fetcher
*/
private ComboBox<SearchBasedFetcher> createFetcherComboBox() {
ComboBox<SearchBasedFetcher> fetchers = new ComboBox<>();
private SearchableComboBox<SearchBasedFetcher> createFetcherComboBox() {
SearchableComboBox<SearchBasedFetcher> fetchers = new SearchableComboBox<>();
new ViewModelListCellFactory<SearchBasedFetcher>()
.withText(SearchBasedFetcher::getName)
.install(fetchers);
Expand Down
4 changes: 2 additions & 2 deletions jabgui/src/main/java/org/jabref/gui/preferences/customentrytypes/CustomEntryTypesTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import javafx.fxml.FXML;
import javafx.scene.Group;
import javafx.scene.control.Button;
import javafx.scene.control.ComboBox;
import javafx.scene.control.Label;
import javafx.scene.control.TableColumn;
import javafx.scene.control.TableRow;
Expand Down Expand Up @@ -40,6 +39,7 @@
import com.tobiasdiez.easybind.EasyBind;
import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
import jakarta.inject.Inject;
import org.controlsfx.control.SearchableComboBox;

public class CustomEntryTypesTab extends AbstractPreferenceTabView<CustomEntryTypesTabViewModel> implements PreferencesTab {

Expand All @@ -52,7 +52,7 @@ public class CustomEntryTypesTab extends AbstractPreferenceTabView<CustomEntryTy
@FXML private TableColumn<FieldViewModel, Boolean> fieldTypeColumn;
@FXML private TableColumn<FieldViewModel, String> fieldTypeActionColumn;
@FXML private TableColumn<FieldViewModel, Boolean> fieldTypeMultilineColumn;
@FXML private ComboBox<Field> addNewField;
@FXML private SearchableComboBox<Field> addNewField;
@FXML private Button addNewEntryTypeButton;
@FXML private Button addNewFieldButton;

Expand Down
4 changes: 2 additions & 2 deletions jabgui/src/main/java/org/jabref/gui/preferences/external/ExternalTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import javafx.fxml.FXML;
import javafx.scene.control.Button;
import javafx.scene.control.CheckBox;
import javafx.scene.control.ComboBox;
import javafx.scene.control.TextField;

import org.jabref.gui.actions.ActionFactory;
Expand All @@ -20,12 +19,13 @@

import com.airhacks.afterburner.views.ViewLoader;
import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
import org.controlsfx.control.SearchableComboBox;

public class ExternalTab extends AbstractPreferenceTabView<ExternalTabViewModel> implements PreferencesTab {

@FXML private TextField eMailReferenceSubject;
@FXML private CheckBox autoOpenAttachedFolders;
@FXML private ComboBox<GuiPushToApplication> pushToApplicationCombo;
@FXML private SearchableComboBox<GuiPushToApplication> pushToApplicationCombo;
@FXML private TextField citeCommand;
@FXML private Button autolinkExternalHelp;

Expand Down
3 changes: 2 additions & 1 deletion jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@
import com.tobiasdiez.easybind.EasyBind;
import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
import jakarta.inject.Inject;
import org.controlsfx.control.SearchableComboBox;

public class GeneralTab extends AbstractPreferenceTabView<GeneralTabViewModel> implements PreferencesTab {

@FXML private ComboBox<Language> language;
@FXML private SearchableComboBox<Language> language;
@FXML private ComboBox<ThemeTypes> theme;
@FXML private CheckBox themeSyncOs;
@FXML private TextField customThemePath;
Expand Down
4 changes: 2 additions & 2 deletions ...i/src/main/resources/org/jabref/gui/preferences/customentrytypes/CustomEntryTypesTab.fxml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.scene.control.Button?>
<?import javafx.scene.control.ComboBox?>
<?import javafx.scene.control.Label?>
<?import javafx.scene.control.TableColumn?>
<?import javafx.scene.control.TableView?>
Expand All @@ -11,6 +10,7 @@
<?import javafx.scene.layout.Region?>
<?import javafx.scene.layout.VBox?>
<?import org.jabref.gui.icon.JabRefIconView?>
<?import org.controlsfx.control.SearchableComboBox?>
<fx:root spacing="10.0" type="VBox"
xmlns="http://javafx.com/javafx" xmlns:fx="http://javafx.com/fxml"
fx:controller="org.jabref.gui.preferences.customentrytypes.CustomEntryTypesTab">
Expand Down Expand Up @@ -61,7 +61,7 @@
</columnResizePolicy>
</TableView>
<HBox spacing="10.0" alignment="BASELINE_CENTER">
<ComboBox fx:id="addNewField" editable="true" prefWidth="150.0"/>
<SearchableComboBox fx:id="addNewField" editable="true" prefWidth="150.0"/>
<Button fx:id="addNewFieldButton"
prefHeight="20.0" prefWidth="20.0"
styleClass="icon-button,narrow" onAction="#addNewField">
Expand Down
6 changes: 3 additions & 3 deletions jabgui/src/main/resources/org/jabref/gui/preferences/external/ExternalTab.fxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<?import javafx.scene.control.Button?>
<?import javafx.scene.control.CheckBox?>
<?import javafx.scene.control.ComboBox?>
<?import javafx.scene.control.Label?>
<?import javafx.scene.control.TextField?>
<?import javafx.scene.control.Tooltip?>
Expand All @@ -12,6 +11,7 @@
<?import javafx.scene.layout.RowConstraints?>
<?import javafx.scene.layout.VBox?>
<?import org.jabref.gui.icon.JabRefIconView?>
<?import org.controlsfx.control.SearchableComboBox?>
<fx:root spacing="10.0" type="VBox"
xmlns="http://javafx.com/javafx" xmlns:fx="http://javafx.com/fxml"
fx:controller="org.jabref.gui.preferences.external.ExternalTab">
Expand Down Expand Up @@ -41,8 +41,8 @@
<RowConstraints minHeight="10.0" vgrow="SOMETIMES"/>
</rowConstraints>
<Label text="%Application to push entries to"/>
<ComboBox fx:id="pushToApplicationCombo"
prefWidth="200.0" GridPane.columnIndex="1"/>
<SearchableComboBox fx:id="pushToApplicationCombo"
prefWidth="200.0" GridPane.columnIndex="1"/>
Copy link
Member

@calixtus calixtus Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editable false?

Copy link
Author

@CodeRishiX CodeRishiX Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out. I have added editable="false" as suggested.
I will push the updated code shortly.

<Button styleClass="icon-button,narrow" onAction="#pushToApplicationSettings"
prefHeight="20.0" prefWidth="20.0" GridPane.columnIndex="2">
<graphic>
Expand Down
3 changes: 2 additions & 1 deletion jabgui/src/main/resources/org/jabref/gui/preferences/general/GeneralTab.fxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<?import javafx.scene.layout.HBox?>
<?import javafx.scene.layout.VBox?>
<?import org.jabref.gui.icon.JabRefIconView?>
<?import org.controlsfx.control.SearchableComboBox?>
<fx:root spacing="10.0" type="VBox"
xmlns="http://javafx.com/javafx" xmlns:fx="http://javafx.com/fxml"
fx:controller="org.jabref.gui.preferences.general.GeneralTab">
Expand All @@ -28,7 +29,7 @@
GridPane.rowIndex="0" GridPane.columnIndex="0" GridPane.columnSpan="3"/>
<Label text="%Language"
GridPane.rowIndex="1" GridPane.columnIndex="0"/>
<ComboBox fx:id="language" prefWidth="200.0"
<SearchableComboBox fx:id="language" prefWidth="200.0" editable="false"
GridPane.rowIndex="1" GridPane.columnIndex="1"/>

<Label text="%Visual theme"
Expand Down
Loading