-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(merge-dialog): fix 'treat duplicates the same way' checkbox #14224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| ### Fixed | ||
|
|
||
| - We fixed the checkbox in merge dialog "Treat duplicates the same way". Now it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue number
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java
Show resolved
Hide resolved
|
|
||
| ### Fixed | ||
|
|
||
| - We fixed the checkbox in merge dialog "Treat duplicates the same way". Now it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - We fixed the checkbox in merge dialog "Treat duplicates the same way". Now it works | |
| - We fixed the checkbox in merge dialog "Treat duplicates the same way" to make it functional. |
and add issue number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to link melting pot issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use the PR number then
| private final TaskExecutor taskExecutor; | ||
|
|
||
| // For "apply to all entries" functionality. | ||
| private DuplicateResolverResult rememberedDecision = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for uniformity
| private DuplicateResolverResult rememberedDecision = null; | |
| private DuplicateResolverResult rememberedDecision; |
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/720
Previously, if your library had a lot of duplicate entries, and you want to quickly merge them, you couldn't do this easily. There is a checkbox "Treat duplicates the same way", but it never worked. This PR solves this program, and it works now like this:
Scenario 1:
Scenario 2:
Scenario 3 (checkbox was ticked previously):
I put Scenario 3 here, because even if the checkbox is ticked, there is a way to untick it.
Steps to test
After that JabRef merges duplicates automatically.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)