-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(slr): run duplicate check after finding papers #14226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
InAnYan
wants to merge
5
commits into
JabRef:main
Choose a base branch
from
InAnYan:feat/duplicates-slr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fb80202
feat(slr): run duplicate check after finding papers
InAnYan 2d70b7f
fix(duplicates): remove unnecessary local var
InAnYan 044fd1b
Merge branch 'upstream-main' into feat/duplicates-slr
InAnYan 978b8a9
chore(changelog): add changelog entry
InAnYan 636e413
refactor(slr): add more meaningful log
InAnYan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
53 changes: 53 additions & 0 deletions
53
jablib/src/main/java/org/jabref/logic/crawler/AutomaticDuplicateRemover.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| package org.jabref.logic.crawler; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| import org.jabref.logic.database.DuplicateCheck; | ||
| import org.jabref.model.database.BibDatabase; | ||
| import org.jabref.model.database.BibDatabaseContext; | ||
| import org.jabref.model.entry.BibEntry; | ||
| import org.jabref.model.entry.BibEntryTypesManager; | ||
|
|
||
| public class AutomaticDuplicateRemover { | ||
| private final BibEntryTypesManager bibEntryTypesManager; | ||
|
|
||
| public AutomaticDuplicateRemover(BibEntryTypesManager bibEntryTypesManager) { | ||
| this.bibEntryTypesManager = bibEntryTypesManager; | ||
| } | ||
|
|
||
| public void removeDuplicates(BibDatabaseContext databaseContext) { | ||
| DuplicateCheck duplicateCheck = new DuplicateCheck(bibEntryTypesManager); | ||
| BibDatabase database = databaseContext.getDatabase(); | ||
| List<BibEntry> entries = database.getEntries(); | ||
| List<BibEntry> entriesToRemove = new ArrayList<>(); | ||
| Set<BibEntry> handledEntries = new HashSet<>(); | ||
|
|
||
| for (int i = 0; i < entries.size(); i++) { | ||
| BibEntry entry1 = entries.get(i); | ||
| if (handledEntries.contains(entry1)) { | ||
| continue; | ||
| } | ||
|
|
||
| for (int j = i + 1; j < entries.size(); j++) { | ||
| BibEntry entry2 = entries.get(j); | ||
| if (handledEntries.contains(entry2)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (duplicateCheck.isDuplicate(entry1, entry2, databaseContext.getMode())) { | ||
| entry1.mergeWith(entry2); | ||
| entriesToRemove.add(entry2); | ||
| handledEntries.add(entry2); | ||
| } | ||
| } | ||
| handledEntries.add(entry1); | ||
| } | ||
|
|
||
| for (BibEntry entry : entriesToRemove) { | ||
| database.removeEntry(entry); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way the looping is done now, it is guaranteed that you won't "handle" the same pair of entries twice, so the handledEntries set and the conditions are redundant.