Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package org.jabref.logic.crawler;

import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

import org.jabref.logic.database.DuplicateCheck;
import org.jabref.model.database.BibDatabase;
import org.jabref.model.database.BibDatabaseContext;
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.BibEntryTypesManager;

public class AutomaticDuplicateRemover {
private final BibEntryTypesManager bibEntryTypesManager;

public AutomaticDuplicateRemover(BibEntryTypesManager bibEntryTypesManager) {
this.bibEntryTypesManager = bibEntryTypesManager;
}

public void removeDuplicates(BibDatabaseContext databaseContext) {
DuplicateCheck duplicateCheck = new DuplicateCheck(bibEntryTypesManager);
BibDatabase database = databaseContext.getDatabase();
List<BibEntry> entries = database.getEntries();
List<BibEntry> entriesToRemove = new ArrayList<>();
Set<BibEntry> handledEntries = new HashSet<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the looping is done now, it is guaranteed that you won't "handle" the same pair of entries twice, so the handledEntries set and the conditions are redundant.


for (int i = 0; i < entries.size(); i++) {
BibEntry entry1 = entries.get(i);
if (handledEntries.contains(entry1)) {
continue;
}

for (int j = i + 1; j < entries.size(); j++) {
BibEntry entry2 = entries.get(j);
if (handledEntries.contains(entry2)) {
continue;
}

if (duplicateCheck.isDuplicate(entry1, entry2, databaseContext.getMode())) {
entry1.mergeWith(entry2);
entriesToRemove.add(entry2);
handledEntries.add(entry2);
}
}
handledEntries.add(entry1);
}

for (BibEntry entry : entriesToRemove) {
database.removeEntry(entry);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@
import java.nio.file.Path;
import java.time.LocalDateTime;
import java.time.temporal.ChronoUnit;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

import org.jabref.logic.JabRefException;
import org.jabref.logic.citationkeypattern.CitationKeyGenerator;
import org.jabref.logic.database.DatabaseMerger;
import org.jabref.logic.database.DuplicateCheck;
import org.jabref.logic.exporter.AtomicFileWriter;
import org.jabref.logic.exporter.BibDatabaseWriter;
import org.jabref.logic.exporter.BibWriter;
Expand Down Expand Up @@ -419,6 +423,9 @@ private void persistResults(List<QueryResult> crawlResults) throws IOException,
// Merge new entries into study result file
merger.merge(existingStudyResultEntries.getDatabase(), newStudyResultEntries);

LOGGER.info("Removing duplicates...");
new AutomaticDuplicateRemover(bibEntryTypesManager).removeDuplicates(existingStudyResultEntries);

writeResultToFile(getPathToStudyResultFile(), existingStudyResultEntries);
}

Expand Down Expand Up @@ -463,4 +470,5 @@ private Path getPathToStudyResultFile() {
private Path getPathToQueryDirectory(String query) {
return repositoryPath.resolve(trimNameAndAddID(query));
}

}
Loading