-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add "preferences" constant to ServiceLocator initialization #14810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||||
subhramit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving based on discussion in call/chat
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
…es/jablib/src/main/resources/csl-locales-50e46eb * upstream/main: (119 commits) chore(sbom): update CycloneDX SBOM files (#14813) Add "preferences" constant to ServiceLocator initialization (#14810) adjust bom generation to only use runtime (#14809) Remove (nearly) obsolete hint in ghprcomment.yml Update dependency org.apache.commons:commons-lang3 to v3.20.0 (#14808) Fix Nullwarnings - B (#14802) Add https Add ouput Fix stale (again) Fix output Fix re-downloading of ltwa file Chore(deps): Bump jablib/src/main/resources/csl-styles from `9bb1fc1` to `0201999` (#14796) Chore(deps): Bump org.ow2.asm:asm from 9.9 to 9.9.1 in /versions (#14799) Chore(deps): Bump org.controlsfx:controlsfx in /versions (#14800) Chore(deps): Bump org.postgresql:postgresql in /versions (#14798) Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#14795) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#14797) Chore(deps): Bump org.apache.commons:commons-text from 1.14.0 to 1.15.0 in /versions (#14801) fix postgres for arm (#14792) Docs: minor grammar and clarity fixes in privacy policy (#14786) ...
User description
Closes #14807
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)PR Type
Bug fix
Description
Add name and type parameters to preferences constant registration
Ensures proper dependency injection of CliPreferences in ServiceLocator
Fixes issue HTTP server endpoint /libraries/demo fails (returns HTTP 500 with HTML), breaking demo library retrieval. #14807 with preferences initialization
Diagram Walkthrough
File Walkthrough
Server.java
Add name and type to preferences constant registrationjabsrv/src/main/java/org/jabref/http/server/Server.java
addOneConstantcall for preferences to include name parameter"preferences"
CliPreferences.classfor proper type binding