Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jan 12, 2026

User description

Workaround for michel-kraemer/gradle-download-task#423

Follow-up to #14725

Steps to test

See gradle running again in the IDE

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

PR Type

Bug fix


Description

  • Disable Gradle configuration cache due to upstream issue

  • Workaround for gradle-download-task incompatibility

  • Allows Gradle to run properly in IDE environments


Diagram Walkthrough

flowchart LR
  A["gradle.properties"] -- "disable configuration cache" --> B["org.gradle.configuration-cache=false"]
  B -- "reference issue" --> C["gradle-download-task#423"]
Loading

File Walkthrough

Relevant files
Bug fix
gradle.properties
Disable Gradle configuration cache setting                             

gradle.properties

+2/-1     

@koppor koppor added dev: build-system automerge PR is tagged with that label will be merged if workflows are green labels Jan 12, 2026
@qodo-free-for-open-source-projects
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟢
🎫 #423
🟢 Address incompatibility issue with gradle-download-task that prevents Gradle from running
properly
Implement a workaround to allow Gradle to function in IDE environments
🟡
🎫 #423
🔴 Handle unsupported entry type "other" in JabRef 3.0+
Convert unknown entry types to 'Misc' instead of 'Other'
Potentially add a conversion dialog for reading bib files with unsupported entry types
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-free-for-open-source-projects
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Align parallel configuration with cache setting

To avoid confusion, set org.gradle.configuration-cache.parallel to false as it
is only effective when org.gradle.configuration-cache is enabled.

gradle.properties [9-10]

 org.gradle.configuration-cache=false
-org.gradle.configuration-cache.parallel=true
+org.gradle.configuration-cache.parallel=false
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly notes that org.gradle.configuration-cache.parallel is ineffective when the main cache is disabled, and the proposed change improves configuration clarity and consistency.

Low
  • More

@Siedlerchr Siedlerchr disabled auto-merge January 12, 2026 19:42
@Siedlerchr
Copy link
Member

Wh? It still works with configuration

@koppor
Copy link
Member Author

koppor commented Jan 12, 2026

grafik

@koppor koppor removed the automerge PR is tagged with that label will be merged if workflows are green label Jan 12, 2026
@Siedlerchr
Copy link
Member

grafik

@koppor
Copy link
Member Author

koppor commented Jan 12, 2026

Neverymind - it was

+    onlyIf {
+        !ltwaCsvFile.get().asFile.exists()
+    }

@Siedlerchr
Copy link
Member

Only happens in offline mode

@koppor koppor closed this Jan 12, 2026
@koppor koppor deleted the koppor-patch-1-1 branch January 12, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants