Skip to content

test: add missing test cases for Windows filename characters #14937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Siedlerchr merged 2 commits into from
Jan 27, 2026
Merged

test: add missing test cases for Windows filename characters #14937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b6f746
test: add missing test cases for Windows filename characters
gluck243 Jan 27, 2026
1b8b020
test: add backslash case suggested by reviewer
gluck243 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jablib/src/test/java/org/jabref/logic/util/FileNameCleanerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ class FileNameCleanerTest {
"illegalFilename______.txt, illegalFilename/?*<>|.txt",
"illegalFileName_.txt, illegalFileName{.txt",
"_The Evolution of Sentiment_ Analysis_.PDF, ?The Evolution of Sentiment} Analysis}.PDF",
"'The Evolution of Sentiment_ Analysis_A Review of Research Topics, Venues, and Top Cited Papers.PDF', 'The Evolution of Sentiment} Analysis}A Review of Research Topics, Venues, and Top Cited Papers.PDF'"
"'The Evolution of Sentiment_ Analysis_A Review of Research Topics, Venues, and Top Cited Papers.PDF', 'The Evolution of Sentiment} Analysis}A Review of Research Topics, Venues, and Top Cited Papers.PDF'",
"file_with_colon.txt, file:with:colon.txt",
"file_with_quote.txt, file\"with\"quote.txt",
"file_with_backslash.txt, file\\with\\backslash.txt"
})
void cleanFileName(String expected, String input) {
assertEquals(expected, FileNameCleaner.cleanFileName(input));
Expand Down
Loading