Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Fixed

- We fixed pages checker to allow suffix letters in the page range like "436S-439S". [#13701](https://github.com/JabRef/jabref/issues/13701)
- We fixed an issue where the Web search table had extra space, to improve the layout. [#14556](https://github.com/JabRef/jabref/issues/14556)
- We fixed an issue where the side pane (Groups/Web search) width was not remembered after restarting JabRef. [#8907](https://github.com/JabRef/jabref/issues/8907)
- We fixed the ScienceDirect fulltext fetcher not returning a PDF when the Elsevier API response includes a direct PDF link. [#12161](https://github.com/JabRef/jabref/issues/12161)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

public class PagesChecker implements ValueChecker {

private static final String SINGLE_PAGE_PATTERN = "[A-Za-z]?\\d*"; // optional prefix and number
private static final String SINGLE_PAGE_PATTERN = "[A-Za-z]?\\d*[A-Za-z]?"; // optional prefix, numbers, and optional suffix
private static final String BIBTEX_RANGE_SEPARATOR = "(\\+|-{2}|\u2013)"; // separator, must contain exactly two dashes
private static final String BIBLATEX_RANGE_SEPARATOR = "(\\+|-{1,2}|\u2013)"; // separator

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ public static Stream<String> bibtexAccepts() {
// bibTexAcceptsNoSimpleRangeOfNumbers
"43+",
// bibTexAcceptsMorePageNumbersWithRangeOfNumbers
"7+,41--43,73"
"7+,41--43,73",
// suffix
"436S-439S"
);
}

Expand All @@ -56,7 +58,9 @@ public static Stream<String> bibtexRejects() {
// bibTexDoesNotAcceptMorePageNumbersWithoutComma
"1 2",
// bibTexDoesNotAcceptBrackets
"{1}-{2}"
"{1}-{2}",
// More than one suffix forbidden
"436SS-439S"
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ public static Stream<String> bibtexAccepts() {
// bibTexAcceptsNoSimpleRangeOfNumbers
"43+",
// bibTexAcceptsMorePageNumbersWithRangeOfNumbers
"7+,41--43,73"
"7+,41--43,73",
// suffix
"436S--439S"
);
}

Expand All @@ -56,7 +58,9 @@ public static Stream<String> bibtexRejects() {
// bibTexDoesNotAcceptMorePageNumbersWithoutComma
"1 2",
// bibTexDoesNotAcceptBrackets
"{1}-{2}"
"{1}-{2}",
// single dash forbidden
"436S-439S"
);
}

Expand Down
Loading