-
-
Notifications
You must be signed in to change notification settings - Fork 8
release: next (#8) #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c636ac2 to
18e87c5
Compare
* ci(github): add lint and test workflows (#3) * chore(spellcheck): add a spelling dictionary (#5) * chore(spellcheck): add a spelling dictionary * chore: add codespell workflow and fix typo in README --------- Co-authored-by: Tommy Dorsey <[email protected]> * chore(gitignore): ignore venvs, build artifacts, etc (#4) * chore(manifest): set quality scale explicitly (#1) Co-authored-by: Tommy Dorsey <[email protected]> * style(pre-commit): add initial ruleset (#7) * docs(README): add information on running tests and linters * style(pre-commit): create initial configuration --------- * build: create pyproject with uv (#6) * test: verify test configuration (#2) * ci(codespell): fix cspell command syntax ---------
JackJPowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project is soon to be archived. It's the custom integration that I got included in core last week. It is now maintained in the homeassistant/core repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original order is correct
quality_scale should be set to custom, if set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
custom integrations do not get a graded quality scale.
| dependencies = [ | ||
| "PSNAWP==3.0.0", | ||
| "pyrate-limiter>=3.7.0", | ||
| "PyTurboJPEG", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything PyTurbo, aiohttp... are dev dependencies. Pieces to attempt to clear up some core integration errors in HA but aren't needed by mine.
ci(github): add lint and test workflows
chore(spellcheck): add a spelling dictionary
chore(spellcheck): add a spelling dictionary
chore: add codespell workflow and fix typo in README
chore(gitignore): ignore venvs, build artifacts, etc
chore(manifest): set quality scale explicitly
style(pre-commit): add initial ruleset
docs(README): add information on running tests and linters
style(pre-commit): create initial configuration
build: create pyproject with uv
test: verify test configuration
ci(codespell): fix cspell command syntax