Improve HDMI source naming and hide empty App List entity#30
Open
fbutler wants to merge 2 commits intoJackJPowell:mainfrom
Open
Improve HDMI source naming and hide empty App List entity#30fbutler wants to merge 2 commits intoJackJPowell:mainfrom
fbutler wants to merge 2 commits intoJackJPowell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Friendly names provided by SmartThings are now incorporated into the HDMI source names, allowing both the HDMI port number and the configured device name to be displayed.
HDMI inputs are sorted numerically even when friendly names are used.
Friendly HDMI names are mapped correctly back to their SmartThings input identifiers when selecting a source.
The App List select entity is no longer created when the TV does not report any installed apps.
Example
Instead of generic HDMI names such as:
HDMI1
HDMI2
HDMI3
the integration can now display all or part of the SmartThings configured names:
HDMI 1 Sky
HDMI 2 Blu-Ray
HDMI 3 Q70T Soundbar
This makes it easier to identify and select the correct input source from the Remote Two/3 start sequence and widget edit interfaces.
Motivation
SmartThings exposes friendly input names that reflect the devices connected to each HDMI port.
Previously these names were visible in the integration as separate sources in addition to the TV and HDMI ports, however they didn't work when selected.
This change surfaces the SmartThings input names while preserving the HDMI port number, improving usability without altering existing behaviour.
Compatibility
If SmartThings input names are not available, the integration falls back to the existing HDMI source list (HDMI, HDMI1, HDMI2, etc.), preserving current behaviour.
Testing
Tested with multiple Samsung TVs using SmartThings input source mappings.
The App List entity behaviour has been verified to hide the entity when no apps are reported by the TV. Launching apps from the App List has not been tested because none of the tested TVs expose an application list.