Switch ch Sentence constructor from using HasUID to IsChunk.#4725
Switch ch Sentence constructor from using HasUID to IsChunk.#4725JacquesCarette merged 6 commits intomainfrom
ch Sentence constructor from using HasUID to IsChunk.#4725Conversation
…o switchHasUIDNamedIdeaAndCh
balacij
requested review from
JacquesCarette,
cd155 and
samm82
as code owners
This will simplify work necessary for re-writing #4716. As a result of this, it was sensible to also replace `HasUID` usage in `NamedIdea` to `IsChunk` as well (this results in a smaller diff, and is sensible; `UID`s should be best kept as 'secret' as possible, even though this doesn't really do that).
balacij
force-pushed
the
switchChIsChunkNoUID
branch
from
06d420e to
216fcd5
Compare
|
Merged in |
| definedIn''' :: (HasSymbol q, HasUID q, Referable r, HasShortName r) => q -> r -> Sentence | ||
| -- | Takes a 'Symbol' and its 'Reference' (does not append a period at the | ||
| -- end!). Outputs as "@symbol@ is defined in @source@". | ||
| definedIn''' :: (Quantity q, Referable r, HasShortName r) => q -> r -> Sentence |
There was a problem hiding this comment.
I don't mind not using HasUID directly in most code, but replacing HasSymbol with Quantity, even though it appears that things still work, seem like too radical a narrowing. Doesn't Quantity imply quite a few more things, none of which are actually needed?
Why not just change HasUID to IsChunk and leave the HasSymbol alone?
There was a problem hiding this comment.
Looks like I was rushing and didn't think this one through fully -- it can have a broader scope. d620ad4 fixes this.
There was a problem hiding this comment.
Yes, but you only did it in this one spot, while the same narrow scope occurred in most of the other files you edited.
There was a problem hiding this comment.
Ah, thank you. 0a46379 resolves the remaining ones now.
3 participants
Builds on #4723 and #4724
This will simplify work necessary for re-writing #4716.
As a result of this, it was sensible to also replace
HasUIDusage inNamedIdeatoIsChunkas well (this results in a smaller diff, and issensible;
UIDs should be best kept as 'secret' as possible, eventhough this doesn't really do that).