Open
Conversation
B-rando1
commented
Feb 14, 2026
| import Drasil.GOOL (ProgData, onCodeList) | ||
|
|
||
| -- | The underlying data type for packages in all renderers. | ||
| data PackageData a = PackD {packageProg :: a, packageAux :: [FileAndContents]} |
Collaborator
Author
There was a problem hiding this comment.
I know we only just added the type parameter in #4643 (to remove an import of ProgData from Drasil.GOOL), but since we need ProgData anyway for package, it might make sense to take it out and have packageProg :: ProgData. I tried this locally; it was very easy and didn't affect the imports at all.
JacquesCarette
requested changes
Feb 14, 2026
Owner
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
Looks fine to me, but since you're going to need to do a merge anyways, might as well also make this change.
| import Drasil.GOOL (ProgData, onCodeList) | ||
|
|
||
| -- | The underlying data type for packages in all renderers. | ||
| data PackageData a = PackD {packageProg :: a, packageAux :: [FileAndContents]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4708
I think I've convinced myself that this is the right change to make. The resulting
PackageDatafile looks a bit odd to me, I think because putting thePackageDatatype in the same file aspackageilluminates how the abstract representation ofPackageDatais only ever concretized in a single way. But maybe it's good that it sticks out, it forces us to consider if this is the best way to express that data structure.At any rate, this will help with #4653, since we can't separate the
SoftwareDossier-related functionality whilePackage-related functionality is in the same files.