Blocks & Codes Comments suggestion #162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call mix deps.get in vscode:prepublish for convenient first build - Add build and install instructions to the readme
Point to elixir-lsp, improve build process and docs
…they are installing. - Register the langId we've already been using in config. Doing so allows us to set elixirLS.trace.server to turn on language server tracing, instead of having to use ElixirLS.trace.server, which is inconsistent with our existing settings.
- Remove Fork from name that shows up within vscode - Change 'ElixirLS configuration" to "ElixirLS" for consistency with other extension settings UI elements
Include fork in published name, register elixirLS as langId, add language server tracing setting UI
Version bump
Add some basic configuration for HTML (EEx) files
From upstream issue: JakeBecker/vscode-elixir-ls#151
Add missing comma
Move the prepublish script into a bash script
…x-fork Add function call syntax
Bump version to v0.2.27
Co-Authored-By: Jason Axelson <[email protected]>
* Update libraries * Introduce eslint By following instructions: https://github.com/typescript-eslint/typescript-eslint/blob/v2.14.0/docs/getting-started/linting/README.md * Introduce prettier * Format code $ npx prettier --write **/*.ts **/*.json .eslintrc.js .vscode/*.json * Format code - Replace tab to space - Intentation to 2 spaces * Fix reports by lint $ npx eslint . --ext .js,.jsx,.ts,.tsx --fix * Fix reports by lint before the change: ``` $ npx eslint . --ext .js,.jsx,.ts,.tsx --fix /Users/niku/src/vscode-elixir-ls/src/extension.ts 20:8 warning Missing return type on function @typescript-eslint/explicit-function-return-type 21:3 error 'testElixir' was used before it was defined @typescript-eslint/no-use-before-define 69:1 warning Missing return type on function @typescript-eslint/explicit-function-return-type 77:1 warning Missing return type on function @typescript-eslint/explicit-function-return-type /Users/niku/src/vscode-elixir-ls/src/test/runTest.ts 5:1 warning Missing return type on function @typescript-eslint/explicit-function-return-type ✖ 5 problems (1 error, 4 warnings) ``` after the change: ``` ❯ npx eslint . --ext .js,.jsx,.ts,.tsx ``` * Fix file permission 755 -> 644 * Add shelljs declaration * Replace duplicated variable `workspaceRoot` https://code.visualstudio.com/docs/editor/variables-reference#_why-isnt-workspaceroot-documented * Fix extentionTestsPath * Fix outFiles path * Make disable other extensions https://code.visualstudio.com/api/working-with-extensions/testing-extension#disabling-other-extensions-while-debugging * Add a smoketest
* Integrate CI * Add a CI status badge to README
Otherwise we are unable to publish a new version of the extension: microsoft/vscode-vsce#389 (comment) also very small elixir-ls update
Will make it easier the next time we have to create a release
Goals:
* By default in most themes, function calls should not be highlighted the same
as function calls
* Most syntaxes only define function definitions, so most themes highlight
those definitions with a rather bold color, applying the same coloring to
all functions calls results in visual noise
* It should still be possible to define custom highlighting for function calls
State of syntax highlighting:
* Textmate syntax highlighting standard (as defined by [1]) defines function
definitions (`entity.name.function`) but says nothing about function calls
* Most themes do not support special coloring for function calls
* We can't expect most themes to add special Elixir support
This PR combines portions of #30 and #38 that have similar goals.
PR #30 by itself did not fully accomplish my goals because function calls are
still annotated with `entity.name.function.elixir` which is highlighted as a
function definition
PR #38 changed the function call names, but it changed it to a non-standard scope.
So in this PR we change the `entity.name.function.elixir` to
`entity.name.function-call.elixir` which allows customization, but is a scope
that that does not have default coloring in most themes (while still being
semantically similar).
Also Ruby's syntax uses the similar `entity.name.function-call.ruby`:
https://github.com/rubyide/vscode-ruby/blob/b232cfd0c96f41ceab72655dcfa17dab40c05562/packages/vscode-ruby/syntaxes/ruby.cson.json#L2243
[1] https://macromates.com/manual/en/language_grammars
|
Hello! I am not a maintainer of this project but would like to let you know that this repository has been inactive since May 2019. There is a fork that is being actively developed by community members, and I recommend you switch over! The GitHub repository is here: And the Visual Studio Code extension is here: If you are having any issues or would like to open any pull requests, please try the new extension or clone the new repository first. You may find that the problem is already resolved 🙂 Thank you and happy Elixiring. |
Author
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not the author but ..i bring it here so it could help!
timmhirsens/vscode-elixir#146 (comment)
from @fklement