record lock approach #202
Merged
record lock approach #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prob has issues stemming from the fact that you can't really hold a lock on something that's been deleted (we try to release lock, but don't validate that it was in the case that it was deleted), or hasn't been inserted yet (we obtain the lock right after inserting). also update rollbacks actually insert another version of the record, instead of readjusting the indirection on the base back one. testAbort.py best shows that this works, updates are rolled back since an insert fails (duplicate primary key)
Owner
Author
|
I see some issues with select with the file
|
Owner
Author
|
There is also a test case added in this PR that causes an error but there doesn't seem to be any issues with existing tests. |
Owner
Author
|
There is also an error with
|
Owner
Author
|
I seemed to fix the issue with the exam_tester but not the m3_tester
|
Collaborator
|
oh wait it does regress |
also remove test
Owner
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prob has issues stemming from the fact that you can't really hold a lock on something that's been deleted (we try to release lock, but don't validate that it was in the case that it was deleted), or hasn't been inserted yet (we obtain the lock right after inserting).
also update rollbacks actually insert another version of the record, instead of readjusting the indirection on the base back one.
testAbort.py best shows that this works, updates are rolled back since an insert fails (duplicate primary key)