Draft
Conversation
Hovering an icon will display a live window preview image. Resolves #157
JakeStanger
force-pushed
the
feat/launcher-previews
branch
from
88a3c7b to
befcd9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering an icon will display a live window preview image.
Resolves #157
This is an EXPERIMENTAL new feature. It works fine (I think) on my machine, but has not been tested anywhere else. As this deals with a fair amount of unsafe code, FFI, and the GPU, it is slightly more prone to going wrong than most features. I've fixed all the crashes I've discovered and Ironbar no longer takes up enough vram to start locking up other processes, but you have been warned...
Currently this relies on
hyprland-toplevel-export-v1, which means currently only Hyprland is supported. Prior to merge, support forext-image-copy-capture-v1will be added, which is currently supported by Sway, COSMIC, Jay, and Treeland. Other compositors (Including Hyprland) should follow behind.This also relies on DMA-BUF being available, which allows for offloading all the image work straight to the GPU. Any modern GPU driver should work with this, but older ones may not be supported, and I've no idea about Nouveau.
This raises the minimum required GTK version to 4.14. As a result, CI is failing due to some deprecated GTK functions. It's also failing because I need to fix the feature flags (I'd recommend building with all features if you want to try this). Everything does build and run okay though.