Added support for getting the cover art from mpd#477
Added support for getting the cover art from mpd#477eternalfrustation wants to merge 15 commits intoJakeStanger:masterfrom
Conversation
There was a problem hiding this comment.
Thanks for taking the time to rewrite this. There are some issues I've raised with your implementation which will need addressing, but it's mostly just simplifying things and refactoring.
In future, can you please have a read of the contributing guide - it's very short but has a few requirements I ask people to stick to in order to make both our lives easier.
The build is also failing currently, which will need to be addressed of course.
As suggested previously, This commit uses message passing to send the image from the client to the main thread while retaining the original way of setting the album art.
Removed the patch section for ahash from Cargo.toml
Due to the previous commit, cargo could not find the proper ahash version, ran cargo update to fix that.
Now using gdk's image parser for parsing the mpd's thumbnails that are read from readpicture command
|
I have done all the requested changes |
|
What kind of Clippy rules are you using |
JakeStanger
left a comment
JakeStanger
left a comment
There was a problem hiding this comment.
Looking a lot better so thanks for the work, there's still a few changes that need to be made. Once those are done I'll give it another review with a fine comb and we should be about there.
The defaults: ironbar/.github/workflows/build.yml Line 61 in 3df01ea |
Only sending the GetAlbumArt signal when track changes and the cover_art path does not exist.
|
Please fix the merge conflict before I review |
JakeStanger
added
M:Music
|
So I have some interest in this and I might take a crack at it, seeing as the effort here has stagnated. It's also a must-have for me - I use only use embedded artwork in my collection, and that, of course, needs to be transmitted explicitly. |
|
Thanks that'd be great if you can. This PR was most of the way there, so it probably doesn't need too much more than rebasing and a quick modernisation pass |
|
Absolutely, though looking at this code, I think I'd better re-write it by hand and just follow it closely. There's a mess of unrelated and questionable changes here. |
|
Go for it - whatever's easiest |
|
Although i have since stopped using ironbar, Let me know if you have any questions regarding this |
|
for now you can use mpd-mpris and change the bar settings to use mpris, cover works here |
4 participants
As proposed in the previous PR (#466), this PR implements displaying cover art from mpd using the readpicture command