Add support to change the volume scrolling on the volume icon#959
Draft
tglman wants to merge 1 commit intoJakeStanger:masterfrom
Draft
Add support to change the volume scrolling on the volume icon#959tglman wants to merge 1 commit intoJakeStanger:masterfrom
tglman wants to merge 1 commit intoJakeStanger:masterfrom
Conversation
JakeStanger
added
M:Volume
JakeStanger
force-pushed
the
WIP_scroll_volume_change
branch
from
e45d368 to
580b24e
Compare
Owner
|
Rebased onto latest master. Currently there's a bug using the mouse wheel, where if you scroll too fast it can crash the client, and take down Ironbar with it: I'm going to convert this to a draft PR for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This add the ability to turn up and down the volume simply scrolling on the volume icon.
it works now but it's still a bit of a work in progress.
I do not have hardware(for another month) to test scroll with a mouse wheel, I think in that case I need to add a
-for some events, that's why there are two different event signals up and down, otherwise would be enough one change (maybe still can be simplified to only one event).Also I saw the WIP migration of GTK4, maybe is easier to way that the migration is done and then rework this on top of that.
Just opening this to make this feature public, even if not yet mainstream.