Skip to content

Conversation

@ebouchut
Copy link

@ebouchut ebouchut commented Oct 28, 2024

My attempt to fix #10

See #10 for details.

when added to extra_javascript:` section
Fix JakubAndrysek#6
@JakubAndrysek
Copy link
Owner

Do I need these changes? Is it better to add this js file first, or is the problem that, in some cases, the append method doesn't work?

Thank you for your work; I am just figuring out why these changes are needed.

Have a nice day

@ebouchut
Copy link
Author

Does not Work

It does not work when deployed on Github-Pages (with a subfolder trio-docs in my case):

open_in_new_tab-gh_pages-ko

Works

It works in:

  • locally with mkdocs serve

OK locally with mkdocs server

With the fix it works locally and when deployed on GH-Pages:

OK with the fix

@ebouchut
Copy link
Author

@JakubAndrysek
For whatever reason, adding js/open-in-new-tab.js first makes it work.
This is why I need your guidance here.
I do not get the reason for now.

@ebouchut ebouchut marked this pull request as draft November 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

js/open-in-new-tab.js not loaded when on GH Pages with a subfolder

2 participants