Added Unity 6 Support #6

DryreL · 2026-01-03T12:23:30Z

Changes

Fixed LayoutUtility for Unity 6 WindowLayout API changes
Updated GameViewUtils to remove NET_4_6 directive
Fixed GUILayout Begin/End mismatch in VideoEditorWelcomeWindow
Added MP4 resolution validation (even dimensions required)
Added dark/light mode text color support for all Editor scripts

Testing

Editor Play button successfully worked without any issues
Verified Welcome Window displays correctly in both themes
All Editor drawers now support light/dark modes

Copilot

Pull request overview

This PR adds Unity 6 compatibility support for a Video Editor Template by addressing API changes in Unity 6 and adding dark/light mode theme support for editor UI components.

Updated WindowLayout API reflection to handle Unity 6's namespace changes with fallback support
Removed NET_4_6 preprocessor directives in favor of runtime constructor detection
Added MP4 format validation requiring even dimensions for H.264 codec compatibility
Implemented dark/light mode text color support across all custom editor scripts

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
VideoEditorWelcomeWindow.cs	Fixed GUILayout Begin/End mismatch, added MP4 dimension validation with user warning, corrected YouTube link bug, and implemented theme-aware text colors
LayoutUtility.cs	Updated WindowLayout type reflection for Unity 6 CoreModule with fallback, added null safety checks for method invocation
GameViewUtils.cs	Removed NET_4_6 directive, replaced with runtime constructor detection for Unity 6 compatibility, added MakeEven helper for MP4 dimension validation
VideoScriptPlayableAssetEditor.cs	Added dark/light mode text color support with runtime theme detection
TransformTweenDrawer.cs	Added GUI.color modifications for light mode label visibility
TimeDilationDrawer.cs	Added GUI.color modifications for light mode label visibility
TextSwitcherDrawer.cs	Added GUI.color modifications for light mode label visibility
ScreenFaderDrawer.cs	Added GUI.color modifications for light mode label visibility
LightControlDrawer.cs	Added GUI.color modifications for light mode label visibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-03T12:25:51Z

Assets/VideoEditorAssets/ModifiedDefaultPlayables/TransformTween/Editor/TransformTweenDrawer.cs

+        Color originalLabelColor = GUI.color;
+        if (!EditorGUIUtility.isProSkin)
+        {
+            GUI.color = new Color(0, 0, 0, 1); // Black for light mode
+        }


Using GUI.color to control label text color is incorrect. GUI.color is a tint that affects all GUI elements including backgrounds, borders, and textures. For controlling text color specifically in PropertyDrawers, you should use the GUIStyle.normal.textColor property or leave the default styling which Unity handles automatically. This implementation may cause unintended visual effects on other GUI elements.

Copilot · 2026-01-03T12:25:52Z

Assets/VideoEditorAssets/ModifiedDefaultPlayables/TimeDilation/Editor/TimeDilationDrawer.cs

+        // Support dark/light mode for label text
+        Color originalLabelColor = GUI.color;
+        if (!EditorGUIUtility.isProSkin)
+        {
+            GUI.color = new Color(0, 0, 0, 1); // Black for light mode
+        }
+
        SerializedProperty timeScaleProp = property.FindPropertyRelative("timeScale");

        Rect singleFieldRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);
        EditorGUI.PropertyField(singleFieldRect, timeScaleProp);
+
+        GUI.color = originalLabelColor;


Using GUI.color to control label text color is incorrect. GUI.color is a tint that affects all GUI elements including backgrounds, borders, and textures. For controlling text color specifically in PropertyDrawers, you should use the GUIStyle.normal.textColor property or leave the default styling which Unity handles automatically. This implementation may cause unintended visual effects on other GUI elements.

Suggested change

// Support dark/light mode for label text

Color originalLabelColor = GUI.color;

if (!EditorGUIUtility.isProSkin)

{

GUI.color = new Color(0, 0, 0, 1); // Black for light mode

}

SerializedProperty timeScaleProp = property.FindPropertyRelative("timeScale");

Rect singleFieldRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);

EditorGUI.PropertyField(singleFieldRect, timeScaleProp);

GUI.color = originalLabelColor;

SerializedProperty timeScaleProp = property.FindPropertyRelative("timeScale");

Rect singleFieldRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);

EditorGUI.PropertyField(singleFieldRect, timeScaleProp);

Copilot · 2026-01-03T12:25:52Z

Assets/VideoEditorAssets/ModifiedDefaultPlayables/TextSwitcher/Editor/TextSwitcherDrawer.cs

+        Color originalLabelColor = GUI.color;
+        if (!EditorGUIUtility.isProSkin)
+        {
+            GUI.color = new Color(0, 0, 0, 1); // Black for light mode
+        }


Using GUI.color to control label text color is incorrect. GUI.color is a tint that affects all GUI elements including backgrounds, borders, and textures. For controlling text color specifically in PropertyDrawers, you should use the GUIStyle.normal.textColor property or leave the default styling which Unity handles automatically. This implementation may cause unintended visual effects on other GUI elements.

Copilot · 2026-01-03T12:25:52Z

Assets/VideoEditorAssets/ModifiedDefaultPlayables/ScreenFader/Editor/ScreenFaderDrawer.cs

+        // Support dark/light mode for label text
+        Color originalLabelColor = GUI.color;
+        if (!EditorGUIUtility.isProSkin)
+        {
+            GUI.color = new Color(0, 0, 0, 1); // Black for light mode
+        }
+
        SerializedProperty colorProp = property.FindPropertyRelative("color");

        Rect singleFieldRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);
        EditorGUI.PropertyField(singleFieldRect, colorProp);
+
+        GUI.color = originalLabelColor;


Using GUI.color to control label text color is incorrect. GUI.color is a tint that affects all GUI elements including backgrounds, borders, and textures. For controlling text color specifically in PropertyDrawers, you should use the GUIStyle.normal.textColor property or leave the default styling which Unity handles automatically. This implementation may cause unintended visual effects on other GUI elements.

Suggested change

// Support dark/light mode for label text

Color originalLabelColor = GUI.color;

if (!EditorGUIUtility.isProSkin)

{

GUI.color = new Color(0, 0, 0, 1); // Black for light mode

}

SerializedProperty colorProp = property.FindPropertyRelative("color");

Rect singleFieldRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);

EditorGUI.PropertyField(singleFieldRect, colorProp);

GUI.color = originalLabelColor;

SerializedProperty colorProp = property.FindPropertyRelative("color");

Rect singleFieldRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);

EditorGUI.PropertyField(singleFieldRect, colorProp);

Copilot · 2026-01-03T12:25:53Z

Assets/VideoEditorAssets/ModifiedDefaultPlayables/LightControl/Editor/LightControlDrawer.cs

+        Color originalLabelColor = GUI.color;
+        if (!EditorGUIUtility.isProSkin)
+        {
+            GUI.color = new Color(0, 0, 0, 1); // Black for light mode
+        }


Using GUI.color to control label text color is incorrect. GUI.color is a tint that affects all GUI elements including backgrounds, borders, and textures. For controlling text color specifically in PropertyDrawers, you should use the GUIStyle.normal.textColor property or leave the default styling which Unity handles automatically. This implementation may cause unintended visual effects on other GUI elements.

Copilot · 2026-01-03T12:25:53Z

Assets/VideoEditorAssets/Scripts/Editor/VideoEditorWelcomeWindow.cs

+            // MP4 format requires even dimensions
+            int adjustedWidth = (width % 2 == 0) ? width : width + 1;
+            int adjustedHeight = (height % 2 == 0) ? height : height + 1;
+
+            if (adjustedWidth != width || adjustedHeight != height)
+            {
+                width = adjustedWidth;
+                height = adjustedHeight;
+                UnityEngine.Debug.LogWarning($"Resolution adjusted to even dimensions for MP4 compatibility: {width}x{height}");
+            }
+


The MP4 resolution validation is being performed twice in different locations (here and in GameViewUtils.AddSetSize). This creates inconsistent behavior: users might see a warning about adjusted dimensions from this code, but GameViewUtils.AddSetSize will adjust again silently. The validation should be performed in only one location to avoid confusion and ensure consistent behavior throughout the application.

Suggested change

// MP4 format requires even dimensions

int adjustedWidth = (width % 2 == 0) ? width : width + 1;

int adjustedHeight = (height % 2 == 0) ? height : height + 1;

if (adjustedWidth != width || adjustedHeight != height)

{

width = adjustedWidth;

height = adjustedHeight;

UnityEngine.Debug.LogWarning($"Resolution adjusted to even dimensions for MP4 compatibility: {width}x{height}");

}

Copilot · 2026-01-03T12:25:53Z

Assets/VideoEditorAssets/Scripts/Editor/GameViewUtils.cs

        {
-            newGvsType = typeof(Editor).Assembly.GetType("UnityEditor.GameViewSizeType.FixedResolution");
+            // Fallback for older Unity versions with int parameter
+            ctor = gvsType.GetConstructor(new Type[] { typeof(int), typeof(int), typeof(int), typeof(string) });


The fallback branch may fail silently if the constructor is not found in older Unity versions. After the fallback constructor lookup, there's no null check before invoking it. If both constructor lookups fail, this will throw a NullReferenceException. Add a null check and appropriate error handling after the fallback constructor lookup.

Suggested change

ctor = gvsType.GetConstructor(new Type[] { typeof(int), typeof(int), typeof(int), typeof(string) });

ctor = gvsType.GetConstructor(new Type[] { typeof(int), typeof(int), typeof(int), typeof(string) });

if (ctor == null)

{

Debug.LogError("GameViewUtils.AddCustomSize: Unable to find a suitable UnityEditor.GameViewSize constructor for this Unity version.");

return;

}

Copilot · 2026-01-03T12:25:54Z

...ts/VideoEditorAssets/ModifiedDefaultPlayables/Video/Editor/VideoScriptPlayableAssetEditor.cs

+        // Ensure label color is set for dark/light mode compatibility
+        if (lStyle.normal.textColor == Color.black)
+        {
+            lStyle.normal.textColor = EditorGUIUtility.isProSkin ? Color.white : Color.black;
+        }



This condition will always be false in light mode. The GetLabelStyle() method already sets the textColor based on the editor skin (line 89), so checking if it equals Color.black and then setting it again is redundant and won't work as expected. This check should be removed since the text color is already properly set in GetLabelStyle().

Suggested change

// Ensure label color is set for dark/light mode compatibility

if (lStyle.normal.textColor == Color.black)

{

lStyle.normal.textColor = EditorGUIUtility.isProSkin ? Color.white : Color.black;

}

…zation

Added Unity 6 Support

6a4f489

Copilot AI review requested due to automatic review settings January 3, 2026 12:23

Copilot started reviewing on behalf of DryreL January 3, 2026 12:23 View session

DryreL mentioned this pull request Jan 3, 2026

Unity 6 Support #5

Open

Copilot AI reviewed Jan 3, 2026

View reviewed changes

DryreL added 25 commits January 3, 2026 17:20

Ignore exported files

075cae7

Package versions updated

85e6135

ProjectSettings updated (Unity 6)

c16eb0d

VideoPlayableBehaviour - Resize to Reinitialize (Unity 6)

757169a

WindowData asset created

aeb8397

TextMesh Pro updated (Unity 6)

9ce229d

SampleScene updated w/other small auto updates

535dd80

Deprecated Visual Studio Code Editor package removed

392be3e

Some unnecessary packages removed for the Demo project

db1fe7c

Timeline package version updated

84dbcd2

Scene postprocessing layer set to Default

7482af1

/.vscode added to Gitignore

9a15761

ModifiedDefaultPlayables - Subtitle Track created (SRT Importer)

6a5a9d9

Subtitle Track added to Timeline & Scene for testing

2f65ba3

Unity Localization package enabled

7d5fade

Unity Localization package assets auto-imported

4a23ae7

SubtitleTrackEditor - Auto string table creation & binding for locali…

2556234

…zation

Localization Settings created

742a604

AddressableAssetsData auto-update

cb2344c

SampleScene auto-update

87e6f14

addressables.android package enabled

bedda16

Default en locale created

0fe3d75

ExampleSignalLogger created and added to Timeline

f5d3732

TimelineControlUI script created

bd981fa

StreamingAssets URL video play feature added (cross-platform)

92676cb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added Unity 6 Support #6

Added Unity 6 Support #6

Uh oh!

DryreL commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Added Unity 6 Support #6

Are you sure you want to change the base?

Added Unity 6 Support #6

Uh oh!

Conversation

DryreL commented Jan 3, 2026

Changes

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant