Skip to content

Execute git commands in correct working directory#120

Merged
JamiLu merged 2 commits intoJamiLu:masterfrom
EtherealAirRhyme:master
Feb 9, 2026
Merged

Execute git commands in correct working directory#120
JamiLu merged 2 commits intoJamiLu:masterfrom
EtherealAirRhyme:master

Conversation

@EtherealAirRhyme
Copy link
Contributor

The plugin previously used cd commands in shell strings to change directories before executing Git commands. On Windows 10, this approach can lead to path resolution problems (especially with spaces or special characters), causing the plugin to fail to locate the git executable.

This PR replaces the cd-based approach with the Node.js spawn's cwd option, which sets the working directory directly and ensures consistent behavior across platforms.

@EtherealAirRhyme
Copy link
Contributor Author

EtherealAirRhyme commented Feb 9, 2026

@JamiLu
I'm sorry, I overlooked the test files. I've submitted new changes, and now it should be fine.

apologies.

Copy link
Owner

@JamiLu JamiLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and support for the extension 💯 🥇

@JamiLu
Copy link
Owner

JamiLu commented Feb 9, 2026

@JamiLu I'm sorry, I overlooked the test files. I've submitted new changes, and now it should be fine.

apologies.

No problem, I was just about to mention about the tests.. Great job. 👍

@JamiLu JamiLu merged commit 584e428 into JamiLu:master Feb 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants