Skip to content

Add a pyjsontool which uses the json format to download files.#123

Merged
JamieSinn merged 5 commits intoJamieSinn:mainfrom
jwhite66:json
Mar 3, 2025
Merged

Add a pyjsontool which uses the json format to download files.#123
JamieSinn merged 5 commits intoJamieSinn:mainfrom
jwhite66:json

Conversation

@jwhite66
Copy link
Contributor

Also add a message when a file is invalid.

@JamieSinn
Copy link
Owner

I'd prefer not to create fractional support here - given the new binary will be multiplatform.

@jwhite66
Copy link
Contributor Author

Sure, I understand your reasoning and this is your call. I'll just note that I have a strong preference for a CLI tool, and a simple one in Python is very compelling to me. What's important is that we all rally behind a single data file.

@JamieSinn
Copy link
Owner

Can you rebase this into a new folder to consolidate the Python stuff?

@jwhite66
Copy link
Contributor Author

I've rebased this branch. It sounds like you'd like to move the python scripts into a separate directory. My inclination would be to create two new subdirectories; an archive and a scripts directory. I would move all of the .CSV files into the archive, along with the pyusbtool.py script; I would rename the pyjsontool.py back to pyusbtool.py and put it in the scripts folder, perhaps with a README. Would you like me to do that?

@JamieSinn
Copy link
Owner

I'll move the old csv files after the 2025 season - as the previous v1 tool will break by doing that and I still want to maintain compat for at least this year - as it looks for the specific root folder CSV - but otherwise that would be great!

@JamieSinn JamieSinn merged commit 28a66a9 into JamieSinn:main Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants