ReadData and DataBlockCodec

[tpietzsch]

follow changes in saalfeldlab/n5#137

[mkitti]

@tpietzsch do we need to wait for saalfeldlab/n5#137 before we merge this?

[mkitti]

Should this be explicitly private as well?

[tpietzsch]

probably, yes

[tpietzsch]

@tpietzsch do we need to wait for saalfeldlab/n5#137 before we merge this?

Yes, please. We are still iterating over that PR as well. This one is just to keep everything building with the SNAPSHOTs. I will also remove the unrelated formatting changes. Maybe best ignore it for now...

[tpietzsch]

I converted it to Draft PR now. Sorry for that oversight...

[tpietzsch]

@mkitti it would be cool if you could merge this and release n5-zstandard-2.0.0-alpha-1

[mkitti]

ok, merging

[mkitti]

I tried running scijava-scripts/release-version.sh to version 2.0.0-alpha-1 but I have no idea if it worked.

@ctrueden ?

[ctrueden]

@mkitti Unfortunately, it appears that the release build failed.

From the log:

Failed to deploy artifacts: Could not transfer artifact org.janelia:n5-zstandard:pom:2.0.0-alpha1 from/to scijava.releases (dav:https://maven.scijava.org/content/repositories/releases): Failed to transfer file: https://maven.scijava.org/content/repositories/releases/org/janelia/n5-zstandard/2.0.0-alpha1/n5-zstandard-2.0.0-alpha1.pom. Return code is: 401

Which indicates that the configured deployment credentials for maven.scijava.org are incorrect.

In February 2024, I had a video call with Don Olbris where we got the credentials added to at least one relevant repository. I vaguely remember that he did not want to set things up the normal SciJava way of adding the credentials to the org as a whole, but rather wanted to add them to one repository at a time. Don has a copy of the credentials and can configure them as needed. I can also meet with you and/or Don again as needed to double check the validity of the credentials.

[tpietzsch]

I can also meet with you and/or Don again as needed to double check the validity of the credentials.

Same here.
You could also make me admin of the repository (temporarily) and I can try to take care of it.

[mkitti]

You are both admins on the repository now:

[ctrueden]

When I logged in to check it, I noticed that this repository had a copy of the secrets added 2 years ago, which was overriding the same secrets added to the entire org 1 year ago. I deleted the (presumably outdated) repository-specific copy of the secrets, in favor of the org-wide ones, reran the release, and got this error instead:

== Configuring Maven ==
  Performing deployment checks
  ==> FAILED: EXIT CODE 1
  No deploy -- could not extract ciManagement URL
  Output of failed attempt follows:
  Error:  Error executing Maven.
  Error:  character 11 is not allowed in output
  Error: en-gpg-plugin version OK: [ERROR] Error executing Maven.
  Error:  character 11 is not allowed in output
  
  == Building the artifact locally only ==
  Error:  Error executing Maven.
  Error:  character 11 is not allowed in output
  ==> FAILED: EXIT CODE 1

I then re-added the secrets to this repository specifically, reran the release again, and this time it worked. ✔️

It seems likely there is something wrong with the repository-wide secrets. I would suggest deleting or updating them.

[tpietzsch]

Thank you @ctrueden !