-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix: add warning if websocket connection isnt open #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docstrings generation was requested by @JarbasAl. * #83 (comment) The following files were modified: * `hivemind_bus_client/client.py`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@hivemind_bus_client/client.py`:
- Around line 236-244: The wait_for_handshake method can recurse indefinitely if
the websocket never opens; change wait_for_handshake to use an iterative retry
loop (or fail fast) instead of unbounded recursion: check
handshake_event.is_set() first, then wait on connected_event with the timeout
and capture the boolean result, and if the connection did not become set after a
bounded number of retries (or a total timeout) raise a TimeoutError or return
False; when connection is set call self.protocol.start_handshake() and loop
until handshake_event is set or retries exhausted. Reference:
wait_for_handshake, handshake_event, connected_event, protocol.start_handshake.
|
Note Docstrings generation - SUCCESS |
* 📝 Add docstrings to `fix/ws_open_chck` Docstrings generation was requested by @JarbasAl. * #83 (comment) The following files were modified: * `hivemind_bus_client/client.py` * Update client.py --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: JarbasAI <[email protected]>
No description provided.