fix: add default content if no activities are found#37
Open
angeloanan wants to merge 1 commit intoJasonEtco:masterfrom
Open
fix: add default content if no activities are found#37angeloanan wants to merge 1 commit intoJasonEtco:masterfrom
angeloanan wants to merge 1 commit intoJasonEtco:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user have not performed any activity for a while, the content that is generated for the gist will be empty.
This PR changes the behavior such that if there is no activity to be displayed, it will show a default empty content.
Sidenote, it looks like the underlying
gist-box(https://github.com/JasonEtco/gist-box) package also suffers a problem where boxes with empty content will basically "clear" the gist file. This will cause a problem since on the next request, no files will be defined (specifically https://github.com/JasonEtco/gist-box/blob/57d4580043b4b1b144cad2979dd2961c67a90f89/src/index.ts#L63).Should I also open a PR to handle it?