Skip to content

Conversation

@JasonShin
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 30, 2025 13:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of DELETE queries that use a USING clause by properly including USING tables when translating the WHERE conditions. Previously, the translator only considered the FROM clause tables, which would cause issues when WHERE conditions reference columns from USING tables.

  • Added support for DELETE...USING statements by combining FROM and USING tables
  • Updated translate_delete function signature to accept table joins parameter
  • Added test case for DELETE with USING clause and table aliases

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
tests/sample/sample.queries.ts New test file with sample query type definitions for select, insert, update, and delete operations
tests/postgres_delete_query_parameters.rs Added test case for DELETE with USING clause to verify proper parameter extraction
src/ts_generator/sql_parser/translate_stmt.rs Modified to combine FROM and USING tables before passing to translate_delete
src/ts_generator/sql_parser/translate_delete.rs Updated function signature to accept table_with_joins parameter instead of None

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 30, 2025 13:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JasonShin JasonShin merged commit 6b37df3 into main Dec 30, 2025
33 checks passed
@JasonShin JasonShin deleted the delete-using branch December 30, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants