Skip to content

fix(no-misused-promises): check either null or undefined #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix(no-misused-promises): check either null or undefined #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/rules/no-misused-observables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export const noMisusedObservablesRule = ruleCreator({
for (const element of node.body.body) {
const tsElement = esTreeNodeToTSNodeMap.get(element);
const memberName = tsElement?.name?.getText();
if (memberName === undefined) {
if (memberName == null) {
// See comment in typescript-eslint no-misused-promises for why.
continue;
}
Expand All @@ -219,7 +219,7 @@ export const noMisusedObservablesRule = ruleCreator({

for (const heritageType of heritageTypes) {
const heritageMember = getMemberIfExists(heritageType, memberName);
if (heritageMember === undefined) {
if (heritageMember == null) {
continue;
}
const memberType = checker.getTypeOfSymbolAtLocation(heritageMember, tsElement);
Expand All @@ -240,7 +240,7 @@ export const noMisusedObservablesRule = ruleCreator({
const tsNode = esTreeNodeToTSNodeMap.get(node);

const contextualType = getPropertyContextualType(checker, tsNode);
if (contextualType === undefined) {
if (contextualType == null) {
return;
}

Expand All @@ -259,7 +259,7 @@ export const noMisusedObservablesRule = ruleCreator({

function checkReturnStatement(node: es.ReturnStatement): void {
const tsNode = esTreeNodeToTSNodeMap.get(node);
if (tsNode.expression === undefined || !node.argument) {
if (tsNode.expression == null || !node.argument) {
return;
}

Expand All @@ -285,7 +285,7 @@ export const noMisusedObservablesRule = ruleCreator({
}

const contextualType = checker.getContextualType(tsNode.expression);
if (contextualType === undefined) {
if (contextualType == null) {
return;
}
if (!isVoidReturningFunctionType(contextualType)) {
Expand Down Expand Up @@ -318,7 +318,7 @@ export const noMisusedObservablesRule = ruleCreator({
function checkVariableDeclaration(node: es.VariableDeclarator): void {
const tsNode = esTreeNodeToTSNodeMap.get(node);
if (
tsNode.initializer === undefined
tsNode.initializer == null
|| !node.init
|| !node.id.typeAnnotation
) {
Expand Down Expand Up @@ -440,11 +440,11 @@ function getPropertyContextualType(
return;
}
const objType = checker.getContextualType(obj);
if (objType === undefined) {
if (objType == null) {
return;
}
const propertySymbol = checker.getPropertyOfType(objType, tsNode.name.text);
if (propertySymbol === undefined) {
if (propertySymbol == null) {
return;
}
return checker.getTypeOfSymbolAtLocation(propertySymbol, tsNode.name);
Expand Down