Skip to content

docs(no-async-subscribe): additional explanation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2024
Merged

docs(no-async-subscribe): additional explanation #26

merged 1 commit into from
Nov 16, 2024

Conversation

@JasonWeinzierl
Copy link
Owner

@JasonWeinzierl JasonWeinzierl commented Nov 16, 2024

I frequently see no-async-subscribe triggered by developers new to RxJS trying to use Promises. Additional explanation of this rule is necessary.

@github-actions
Copy link

github-actions bot commented Nov 16, 2024

LCOV of commit 0f8c929 during .github/workflows/ci.yml #90

Summary coverage rate:
  lines......: 96.3% (3391 of 3520 lines)
  functions..: 95.0% (211 of 222 functions)
  branches...: 91.5% (659 of 720 branches)

Files changed coverage rate: n/a

@JasonWeinzierl JasonWeinzierl merged commit a5e51b1 into main Nov 16, 2024
2 checks passed
@JasonWeinzierl JasonWeinzierl deleted the no-async-docs branch November 16, 2024 17:43
@JasonWeinzierl JasonWeinzierl added the documentation Improvements or additions to documentation label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JasonWeinzierl