Skip to content

feat(no-topromise): suggest lastValueFrom or firstValueFrom #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat(no-topromise): suggest lastValueFrom or firstValueFrom #38

merged 3 commits into from
Nov 21, 2024

Conversation

JasonWeinzierl
Copy link
Owner

@JasonWeinzierl JasonWeinzierl commented Nov 20, 2024 •
edited
Loading

Adds 2 manual editor suggestions to no-topromise. Developers can choose between lastValueFrom, which behaves closest to the deprecated toPromise, or firstValueFrom.

Resolves #37 .

@JasonWeinzierl JasonWeinzierl mentioned this pull request Nov 20, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

LCOV of commit ee0e5dd during .github/workflows/ci.yml #108

Summary coverage rate:
  lines......: 96.3% (3496 of 3631 lines)
  functions..: 95.3% (221 of 232 functions)
  branches...: 91.3% (693 of 759 branches)

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/etc/is.ts                          |70.9%    103|64.3%    28| 100%     18
  src/rules/no-topromise.ts              |94.8%     97| 100%     4|82.6%     23

@JasonWeinzierl JasonWeinzierl added the enhancement New feature or request label Nov 20, 2024
@JasonWeinzierl
test(no-topromise): add coverage for zero imports
6b4e306
@JasonWeinzierl
fix(no-topromise): don't try to fix zero import files
ee0e5dd 
Likely someone is spoofing Observable or maybe RxJS has been embedded in the file?  Weird edge case that we don't need to handle.
@JasonWeinzierl JasonWeinzierl merged commit cec2d60 into main Nov 21, 2024
2 checks passed
@JasonWeinzierl JasonWeinzierl deleted the topromise-suggest branch November 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest lastValueFrom and firstValueFrom as replacements to toPromise
1 participant
@JasonWeinzierl