forked from cartant/eslint-plugin-rxjs
-
Notifications
You must be signed in to change notification settings - Fork 3
feat(no-misused-observables): new rule #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5348ad to
1f23005
Compare
Also fixed invalid JSX.
01f9966 to
fa5e846
Compare
LCOV of commit
|
fe3cb7a to
a8063fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rule based on
@typescript-eslint/no-misused-promises. Ensures you don't return an Observable where void is expected, or try to spread an Observable. This rule is added to thestrictconfiguration.Resolves #43 .
Note:
checksVoidReturnis noticeably slow, specifically stemming from thearguments,properties, andvariablessub-options. It's still faster than@typescript-eslint/no-deprecatedand someimport-xrules, but it's in the top 10 withTIMING=1enabled. But since the implementation is similar to@typescript-eslint/no-misused-promiseswhich has similar performance, we'll allow it.