feat(no-subscribe-in-pipe)!: new rule to forbid calling subscribe within pipe operators #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeinzierl
requested changes
Dec 3, 2024
Danevandy99
force-pushed
the
no-subscribe-in-pipe
branch
from
49f2749 to
7448e49
Compare
|
@JasonWeinzierl This is ready to review again. Thanks for all your work on this! |
JasonWeinzierl
approved these changes
Dec 4, 2024
JasonWeinzierl
changed the title
JasonWeinzierl
requested changes
Dec 4, 2024
Co-authored-by: Jason Weinzierl <[email protected]> Signed-off-by: Dane Vanderbilt <[email protected]>
JasonWeinzierl
approved these changes
Dec 4, 2024
|
CI is failing but merged anyways because seems to be unrelated GitHub Actions permissions issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.