Skip to content

Conversation

JasonWeinzierl
Copy link
Owner

Configuration name is optional but recommended. The old eslintrc format does not support name, but since we don't support eslintrc, we're ok to add name.

  • Add name to recommended and strict configurations. Enforce via unit test.
  • Also add more keywords to the npm package as recommended by eslint.org.

eslint.org recommends adding eslint, eslintplugin, and eslint-plugin keywords to plugin npm packages.
Name is optional but useful in error messages and the config inspector.  It's not supported by old eslintrc, but since we don't support eslintrc, we're fine to add it.
@JasonWeinzierl JasonWeinzierl added this to the v1 milestone Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

LCOV of commit 820c88f during .github/workflows/ci.yml #194

Summary coverage rate:
  lines......: 96.6% (4192 of 4338 lines)
  functions..: 96.0% (267 of 278 functions)
  branches...: 91.0% (918 of 1009 branches)

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/configs/recommended.ts             | 100%     29| 100%     1| 100%      1
  src/configs/strict.ts                  | 100%     41| 100%     1| 100%      1

@JasonWeinzierl JasonWeinzierl merged commit c3b3b33 into main Dec 3, 2024
2 checks passed
@JasonWeinzierl JasonWeinzierl deleted the name-configs branch December 3, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant