Fix windows event log disposed in tests#2321
Open
dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
Open
Fix windows event log disposed in tests#2321dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
Conversation
7ce42c5 to
a375953
Compare
Contributor
Author
|
There are failing tests, but I am shamelessly blaming the main branch. (Checked @jeremydmiller I do believe something should be done with the failing/flaky/cancelled tests in main. New features are cool, but if we don't have stable main it's just an open door for problems. |
Contributor
Author
|
@jeremydmiller My proposals for "something should be done" - #2329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest Alba version to apply JasperFx/alba#211 for Wolverine tests.
This is also continuation of #2218 where as a workaround Wolverine runtime was stopped manually. While it helped for SOME tests (ones based on IntegrationContext) other tests remained flaky.
With the fix from Alba:
Microsoft.Identity.Web.Loggersingleton)IHostis constructed.