Skip to content

Fix windows event log disposed in tests#2321

Open
dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
dmytro-pryvedeniuk:fix-windows-event-log-disposed-in-tests
Open

Fix windows event log disposed in tests#2321
dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
dmytro-pryvedeniuk:fix-windows-event-log-disposed-in-tests

Conversation

@dmytro-pryvedeniuk
Copy link
Contributor

This PR updates to the latest Alba version to apply JasperFx/alba#211 for Wolverine tests.

This is also continuation of #2218 where as a workaround Wolverine runtime was stopped manually. While it helped for SOME tests (ones based on IntegrationContext) other tests remained flaky.

With the fix from Alba:

  • workaround is not needed for IntegrationContext
  • Windows Event Log is disabled thus it can't cause exceptions anymore (includes Microsoft.Identity.Web.Logger singleton)
  • StopAsync is called for Wolverine runtime as expected regardless of how IHost is constructed.

@dmytro-pryvedeniuk dmytro-pryvedeniuk marked this pull request as draft March 18, 2026 18:45
@dmytro-pryvedeniuk dmytro-pryvedeniuk force-pushed the fix-windows-event-log-disposed-in-tests branch from 7ce42c5 to a375953 Compare March 19, 2026 12:14
@dmytro-pryvedeniuk dmytro-pryvedeniuk marked this pull request as ready for review March 19, 2026 13:01
@dmytro-pryvedeniuk
Copy link
Contributor Author

There are failing tests, but I am shamelessly blaming the main branch.

(Checked efcore test, but could not find the right combination to fail Bug_1846_duplicate_execution_of_scheduled_jobs.should_not_double_execute. It's flaky but looks like just in some combination with others)

@jeremydmiller I do believe something should be done with the failing/flaky/cancelled tests in main. New features are cool, but if we don't have stable main it's just an open door for problems.

@dmytro-pryvedeniuk
Copy link
Contributor Author

@jeremydmiller My proposals for "something should be done" - #2329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant