Skip to content

Commit 910f8cf

Browse files
committed
Merge remote-tracking branch 'github/feature-broker-25' into feature-broker-26
# Conflicts: # src/test/groovy/com/ss/mqtt/broker/test/integration/ConnectSubscribePublishTest.groovy
2 parents ef9f008 + 13e7e6a commit 910f8cf

File tree

3 files changed

+16
-121
lines changed

3 files changed

+16
-121
lines changed

src/main/java/com/ss/mqtt/broker/model/SubscribeTopicFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public SubscribeTopicFilter(@NotNull TopicFilter topicFilter, @NotNull QoS qos)
5151
}
5252

5353
@Override
54-
public String toString() {
54+
public @NotNull String toString() {
5555
return "SubscribeTopicFilter(" + "topicFilter=" + topicFilter.getRawTopic() + ", qos=" + qos + ", retainHandling=" +
5656
retainHandling + ", noLocal=" + noLocal + ", retainAsPublished=" + retainAsPublished + ')';
5757
}

src/test/groovy/com/ss/mqtt/broker/test/integration/ConnectSubscribePublishTest.groovy

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
1919
given:
2020
def received = new AtomicReference<Mqtt3Publish>()
2121
def subscriber = buildMqtt311Client()
22-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
22+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
2323
def publisher = buildMqtt311Client()
2424
when:
2525
subscriber.connect().join()
@@ -52,27 +52,27 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
5252
given:
5353
def received = new AtomicReference<Mqtt5Publish>()
5454
def subscriber = buildMqtt5Client()
55-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
55+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
5656
def publisher = buildMqtt5Client()
5757
when:
5858
subscriber.connect().join()
5959
publisher.connect().join()
60-
60+
6161
def subscribeResult = subscribe(subscriber, subscriberId, MqttQos.AT_MOST_ONCE, received)
6262
def publishResult = publish(publisher, subscriberId, MqttQos.AT_MOST_ONCE)
63-
63+
6464
Thread.sleep(100)
6565
then:
6666
noExceptionThrown()
6767

6868
subscribeResult != null
6969
subscribeResult.reasonCodes.contains(Mqtt5SubAckReasonCode.GRANTED_QOS_0)
7070
subscribeResult.type == Mqtt5MessageType.SUBACK
71-
71+
7272
publishResult != null
7373
publishResult.publish.qos == MqttQos.AT_MOST_ONCE
7474
publishResult.publish.type == Mqtt5MessageType.PUBLISH
75-
75+
7676
received.get() != null
7777
received.get().qos == MqttQos.AT_MOST_ONCE
7878
received.get().type == Mqtt5MessageType.PUBLISH
@@ -85,7 +85,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
8585
given:
8686
def received = new AtomicReference<Mqtt3Publish>()
8787
def subscriber = buildMqtt311Client()
88-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
88+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
8989
def publisher = buildMqtt311Client()
9090
when:
9191
subscriber.connect().join()
@@ -118,16 +118,16 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
118118
given:
119119
def received = new AtomicReference<Mqtt5Publish>()
120120
def subscriber = buildMqtt5Client()
121-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
121+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
122122
def publisher = buildMqtt5Client()
123123
when:
124-
124+
125125
subscriber.connect().join()
126126
publisher.connect().join()
127-
127+
128128
def subscribeResult = subscribe(subscriber, subscriberId, MqttQos.AT_LEAST_ONCE, received)
129129
def publishResult = publish(publisher, subscriberId, MqttQos.AT_LEAST_ONCE)
130-
130+
131131
Thread.sleep(100)
132132
then:
133133
noExceptionThrown()
@@ -139,7 +139,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
139139
publishResult != null
140140
publishResult.publish.qos == MqttQos.AT_LEAST_ONCE
141141
publishResult.publish.type == Mqtt5MessageType.PUBLISH
142-
142+
143143
received.get() != null
144144
received.get().qos == MqttQos.AT_LEAST_ONCE
145145
received.get().type == Mqtt5MessageType.PUBLISH
@@ -152,7 +152,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
152152
given:
153153
def received = new AtomicReference<Mqtt3Publish>()
154154
def subscriber = buildMqtt311Client()
155-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
155+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
156156
def publisher = buildMqtt311Client()
157157
when:
158158
subscriber.connect().join()
@@ -185,13 +185,13 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
185185
given:
186186
def received = new AtomicReference<Mqtt5Publish>()
187187
def subscriber = buildMqtt5Client()
188-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
188+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
189189
def publisher = buildMqtt5Client()
190190
when:
191191

192192
subscriber.connect().join()
193193
publisher.connect().join()
194-
194+
195195
def subscribeResult = subscribe(subscriber, subscriberId, MqttQos.EXACTLY_ONCE, received)
196196
def publishResult = publish(publisher, subscriberId, MqttQos.EXACTLY_ONCE)
197197

src/test/groovy/com/ss/mqtt/broker/test/integration/service/PublishRetryServiceTest.groovy

Lines changed: 0 additions & 105 deletions
This file was deleted.

0 commit comments

Comments
 (0)