Skip to content

Fix dataset label mismatch with empty files #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JavaZeroo merged 1 commit into from
Jul 21, 2025
Merged

Fix dataset label mismatch with empty files #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/components/ChartContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,13 +529,12 @@ export default function ChartContainer({
const createChartData = (dataArray, title, yAxisLabel) => {
const datasets = [];

dataArray.forEach((data, index) => {
dataArray.forEach((item, index) => {
const color = colors[index % colors.length];

// Chart data without smoothing

datasets.push({
label: `${parsedData[index]?.name?.replace(/\.(log|txt)$/i, '') || `File ${index + 1}`}`,
data: data,
label: `${item.name?.replace(/\.(log|txt)$/i, '') || `File ${index + 1}`}`,
data: item.data,
borderColor: color,
backgroundColor: `${color}33`, // Add transparency
borderWidth: 2,
Expand Down Expand Up @@ -564,8 +563,8 @@ export default function ChartContainer({
};
};

const createComparisonChartData = (data1, data2, title) => {
const comparisonData = getComparisonData(data1, data2, compareMode);
const createComparisonChartData = (item1, item2, title) => {
const comparisonData = getComparisonData(item1.data, item2.data, compareMode);
const baseline = compareMode === 'relative' ? relativeBaseline :
compareMode === 'absolute' ? absoluteBaseline : 0;

Expand Down Expand Up @@ -657,8 +656,13 @@ export default function ChartContainer({
);
}

const lossDataArray = parsedData.map(file => file.lossData).filter(data => data && data.length > 0);
const gradNormDataArray = parsedData.map(file => file.gradNormData).filter(data => data && data.length > 0);
const lossDataArray = parsedData
.filter(file => file.lossData && file.lossData.length > 0)
.map(file => ({ name: file.name, data: file.lossData }));

const gradNormDataArray = parsedData
.filter(file => file.gradNormData && file.gradNormData.length > 0)
.map(file => ({ name: file.name, data: file.gradNormData }));

// 计算显示的图表数量来决定布局
const enabledFiles = files.filter(file => file.enabled !== false);
Expand Down