Skip to content
This repository was archived by the owner on Oct 24, 2021. It is now read-only.

Conversation

@mabramowski3
Copy link

This should resolve #164 and #89. Works for me now at least. Without making any changes to the code, I could only get repeat while held macros to work by editing the profile's xml file with a text editor.

There were 3 different issues that had to be fixed:

  1. The DS4KeyType flags HoldMacro and RepeatMacro seem to refer to the same feature, but some files use the former and other files use the latter. I changed all instances of RepeatMacro to HoldMacro to fix this.
  2. When saving the profile in ScpUtil.cs, the program would write "HoldMacro" if the hold macro flag is set, and "Macro" if the flag is set. Since both flags are set in the case of a HoldMacro, this results in "HoldMacroMacro" being written"
  3. In RecordBox.cs, the macrorepeat variable is not set to false if the user switches from "repeat while held" to "play once". This meant you could change a Macro to a HoldMacro, but not the other way around without editing the xml file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Macros - Repeat while Held

1 participant